Add 2 Extension APIs for handwriting: experimental.input.sendHandritingStroke and cancelHandWriting

chrome/browser/extensions/extension_input_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_input_api.h"
 
 #include <string>
 
 #include "base/string_util.h"
 #include "base/values.h"
+#include "chrome/browser/chromeos/cros/cros_library.h"
+#include "chrome/browser/chromeos/cros/input_method_library.h"
+#include "chrome/browser/extensions/extension_tabs_module.h"

[Mihai Parparita -not on Chrome, 2011/04/27 23:34:51]

Why do you need this include?

[Yusuke Sato, 2011/04/28 10:57:07]

Removed, thanks.

On 2011/04/27 23:34:51, Mihai Parparita wrote:

 #include "chrome/browser/extensions/key_identifier_conversion_views.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "views/events/event.h"
 #include "views/ime/input_method.h"
 #include "views/widget/widget.h"
 
 namespace {
 
@@ skipping 17 matching lines @@
 
 ui::EventType GetTypeFromString(const std::string& type) {
   if (type == kKeyDown) {
     return ui::ET_KEY_PRESSED;
   } else if (type == kKeyUp) {
     return ui::ET_KEY_RELEASED;
   }
   return ui::ET_UNKNOWN;
 }
 
+bool GetDoubleValue(

[Mihai Parparita -not on Chrome, 2011/04/27 23:34:51]

This is at least the third implementation of such a function (see
ReadNumberByKey in extension_tts_api_util.cc and 
GetNumberValue/GetNumberFromDictionary in json_schema_validator.cc). I think
adding this as a convenience GetNumber method to DictionaryValue is a good idea.

[Yusuke Sato, 2011/04/28 10:57:07]

I did it in a separate CL. Please review http://codereview.chromium.org/6893089/
and http://codereview.chromium.org/6901084/ first.

[Yusuke Sato, 2011/05/02 07:01:02]

Done.

+    const DictionaryValue* dict, const char* key, double* result) {

[Zachary Kuznia, 2011/04/27 10:25:09]

nit: This should fit on the previous line

[Yusuke Sato, 2011/04/28 10:57:07]

I'll remove the function.

On 2011/04/27 10:25:09, Zachary Kuznia wrote:

+  int result_int = 0;
+  // Since number literals in JS like 0.0 and 1.0 are treated as Integers, we
+  // have to call GetInteger() first.
+  if (dict->GetInteger(key, &result_int)) {
+    *result = result_int;
+    return true;
+  }
+  return dict->GetDouble(key, result);
+}
+
 }  // namespace
 
 void InputFunction::Run() {
   SendResponse(RunImpl());
 }
 
 views::Widget* SendKeyboardEventInputFunction::GetTopLevelWidget() {
   Browser* browser = GetCurrentBrowser();
   if (!browser)
     return NULL;
@@ skipping 51 matching lines @@
   views::InputMethod* ime = widget->GetInputMethod();
   if (ime) {
     ime->DispatchKeyEvent(event);
   } else if (!widget->OnKeyEvent(event)) {
     error_ = kKeyEventUnprocessedError;
     return false;
   }
 
   return true;
 }
+
+bool SendHandwritingStrokesFunction::RunImpl() {
+  ListValue* value = NULL;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetList(0, &value));
+
+  chromeos::HandwritingStrokes strokes;
+  for (size_t i = 0; i < value->GetSize(); ++i) {
+    DictionaryValue* dict;
+    double x = 0.0;
+    double y = 0.0;
+    EXTENSION_FUNCTION_VALIDATE(value->GetDictionary(i, &dict));
+    EXTENSION_FUNCTION_VALIDATE(GetDoubleValue(dict, "x", &x));
+    EXTENSION_FUNCTION_VALIDATE(GetDoubleValue(dict, "y", &y));
+    strokes.push_back(std::make_pair(x, y));
+  }
+  chromeos::CrosLibrary::Get()->GetInputMethodLibrary()->

[Mihai Parparita -not on Chrome, 2011/04/27 23:34:51]

Other extensions that use CrosLibrary check if it's loaded (see
http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browser/exten...).
Do you need similar checks here?

[Yusuke Sato, 2011/04/28 10:57:07]

It's definitely better to have the check. Added. Thanks.

On 2011/04/27 23:34:51, Mihai Parparita wrote:

+      SendHandwritingStrokes(strokes);
+  return true;
+}
+
+bool CancelHandwritingFunction::RunImpl() {
+  int n_strokes = 0;  // zero means 'clear all strokes'.
+  if (HasOptionalArgument(0)) {
+    EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &n_strokes));
+  }
+  chromeos::CrosLibrary::Get()->GetInputMethodLibrary()->
+      CancelHandwriting(n_strokes);
+  return true;
+}