Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3356)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_cell.mm

Issue 6905049: Detect removed files and reflect the state in chrome://downloads and the download shelf (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Check |file_externally_removed_| at DownloadItem::CanOpenDownload() Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_item_cell.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_cell.mm b/chrome/browser/ui/cocoa/download/download_item_cell.mm
index 234dc10b656424eabfe4d5fbf2ee47d5a679f24c..ccb6e780d138edd76b092339fde9a143f62fdfe5 100644
--- a/chrome/browser/ui/cocoa/download/download_item_cell.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_cell.mm
@@ -87,6 +87,7 @@ const int kInterruptedAnimationDuration = 2.5;
@interface DownloadItemCell(Private)
- (void)updateTrackingAreas:(id)sender;
+- (void)showSecondaryTitle;
- (void)hideSecondaryTitle;
- (void)animation:(NSAnimation*)animation
progressed:(NSAnimationProgress)progress;
@@ -170,6 +171,7 @@ const int kInterruptedAnimationDuration = 2.5;
// Set status text.
NSString* statusString = base::SysUTF16ToNSString(statusText);
[self setSecondaryTitle:statusString];
+ [self showSecondaryTitle];
isStatusTextVisible_ = YES;
}
@@ -593,6 +595,10 @@ const int kInterruptedAnimationDuration = 2.5;
kImageHeight);
}
+- (void)showSecondaryTitle {
+ [self animation:nil progressed:0.0];
Nico 2011/06/08 22:18:33 Don't you want to animate this in if the title is
haraken1 2011/06/09 05:25:55 Done. I added showStatusAnimation_ for the animati
+}
+
- (void)hideSecondaryTitle {
if (isStatusTextVisible_) {
// No core animation -- text in CA layers is not subpixel antialiased :-/

Powered by Google App Engine
This is Rietveld 408576698