Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3492)

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 6905049: Detect removed files and reflect the state in chrome://downloads and the download shelf (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: is_path_exists_ => file_exists_, aggregate scattered AddObserver()s into one AddObserver() Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/downloads_dom_handler.cc
diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc
index 75209330acf6281ba5b485dfafc317ea080ddd0d..18c04a5e036ef96570f269f5858d5ee1e47405f1 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler.cc
+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc
@@ -124,15 +124,6 @@ void DownloadsDOMHandler::ModelChanged() {
it != download_items_.end(); ++it) {
if (static_cast<int>(it - download_items_.begin()) > kMaxDownloads)
break;
-
- DownloadItem* download = *it;
- if (download->IsInProgress()) {
- // We want to know what happens as the download progresses.
- download->AddObserver(this);
- } else if (download->safety_state() == DownloadItem::DANGEROUS) {
- // We need to be notified when the user validates the dangerous download.
- download->AddObserver(this);
- }
}
SendCurrentDownloads();
@@ -146,6 +137,8 @@ void DownloadsDOMHandler::HandleGetDownloads(const ListValue* args) {
} else {
SendCurrentDownloads();
}
+
+ download_manager_->CheckForFilesRemoval();
}
void DownloadsDOMHandler::HandleOpenFile(const ListValue* args) {
@@ -211,6 +204,9 @@ void DownloadsDOMHandler::SendCurrentDownloads() {
ListValue results_value;
for (OrderedDownloads::iterator it = download_items_.begin();
it != download_items_.end(); ++it) {
+ // Add observers for all download items just once
+ if (!(*it)->HasObserver(this))
+ (*it)->AddObserver(this);
int index = static_cast<int>(it - download_items_.begin());
if (index > kMaxDownloads)
break;

Powered by Google App Engine
This is Rietveld 408576698