Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4746)

Unified Diff: chrome/browser/prefs/pref_value_store.h

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix syncing of platform specific prefs Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_value_store.h
diff --git a/chrome/browser/prefs/pref_value_store.h b/chrome/browser/prefs/pref_value_store.h
index 6a492ba19748949a2dd3357f94d7888560b2971f..597c920c32d520f82987037726133284f85c47ed 100644
--- a/chrome/browser/prefs/pref_value_store.h
+++ b/chrome/browser/prefs/pref_value_store.h
@@ -18,6 +18,7 @@
#include "content/browser/browser_thread.h"
class FilePath;
+class PrefModelAssociator;
class PrefNotifier;
class PrefStore;
@@ -56,6 +57,7 @@ class PrefValueStore {
PrefStore* recommended_platform_prefs,
PrefStore* recommended_cloud_prefs,
PrefStore* default_prefs,
+ PrefModelAssociator* pref_sync_associator,
PrefNotifier* pref_notifier);
virtual ~PrefValueStore();
@@ -69,6 +71,7 @@ class PrefValueStore {
PrefStore* recommended_platform_prefs,
PrefStore* recommended_cloud_prefs,
PrefStore* default_prefs,
+ PrefModelAssociator* pref_sync_associator,
PrefNotifier* pref_notifier);
// Gets the value for the given preference name that has the specified value
@@ -174,6 +177,7 @@ class PrefValueStore {
TestRefreshPolicyPrefsCompletion);
FRIEND_TEST_ALL_PREFIXES(PrefValueStorePolicyRefreshTest,
TestConcurrentPolicyRefresh);
+ FRIEND_TEST_ALL_PREFIXES(PrefValueStoreTest, SyncablePrefs);
// Returns true if the preference with the given name has a value in the
// given PrefStoreType, of the same value type as the preference was
@@ -233,6 +237,9 @@ class PrefValueStore {
// Keeps the PrefStore references in order of precedence.
PrefStoreKeeper pref_stores_[PREF_STORE_TYPE_MAX + 1];
+ // The associator for syncing preferences.
+ PrefModelAssociator* pref_sync_associator_;
+
// Used for generating PREF_CHANGED and PREF_INITIALIZATION_COMPLETED
// notifications. This is a weak reference, since the notifier is owned by the
// corresponding PrefService.

Powered by Google App Engine
This is Rietveld 408576698