Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6022)

Unified Diff: chrome/browser/metrics/metrics_service_uitest.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix syncing of platform specific prefs Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service_uitest.cc
diff --git a/chrome/browser/metrics/metrics_service_uitest.cc b/chrome/browser/metrics/metrics_service_uitest.cc
index 185d3a98ea0b03ad982c3063d2cd07a7d7dfb6e4..6d1ddcfdb776e9355c67ba0fab4d69d55d685b15 100644
--- a/chrome/browser/metrics/metrics_service_uitest.cc
+++ b/chrome/browser/metrics/metrics_service_uitest.cc
@@ -62,10 +62,18 @@ TEST_F(MetricsServiceTest, CloseRenderersNormally) {
QuitBrowser();
scoped_ptr<PrefService> local_state(GetLocalState());
- local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly, true);
- local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount, 0);
- local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount, 0);
- local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount, 0);
+ local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly,
+ true,
+ false /* don't sync pref */);
+ local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount,
+ 0,
+ false /* don't sync pref */);
+ local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount,
+ 0,
+ false /* don't sync pref */);
+ local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount,
+ 0,
+ false /* don't sync pref */);
EXPECT_TRUE(local_state->GetBoolean(prefs::kStabilityExitedCleanly));
EXPECT_EQ(1, local_state->GetInteger(prefs::kStabilityLaunchCount));
EXPECT_EQ(3, local_state->GetInteger(prefs::kStabilityPageLoadCount));
@@ -105,10 +113,18 @@ TEST_F(MetricsServiceTest, DISABLED_CrashRenderers) {
QuitBrowser();
scoped_ptr<PrefService> local_state(GetLocalState());
- local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly, true);
- local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount, 0);
- local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount, 0);
- local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount, 0);
+ local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly,
+ true,
+ false /* don't sync pref */);
+ local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount,
+ 0,
+ false /* don't sync pref */);
+ local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount,
+ 0,
+ false /* don't sync pref */);
+ local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount,
+ 0,
+ false /* don't sync pref */);
EXPECT_TRUE(local_state->GetBoolean(prefs::kStabilityExitedCleanly));
EXPECT_EQ(1, local_state->GetInteger(prefs::kStabilityLaunchCount));
EXPECT_EQ(4, local_state->GetInteger(prefs::kStabilityPageLoadCount));

Powered by Google App Engine
This is Rietveld 408576698