Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6279)

Unified Diff: chrome/browser/first_run/first_run.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix syncing of platform specific prefs Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run/first_run.cc
diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc
index 243732f1073645393ae860d9d85a60869e7e2e67..e439bc8891bfbc65696de9ba2333f93342d58c2b 100644
--- a/chrome/browser/first_run/first_run.cc
+++ b/chrome/browser/first_run/first_run.cc
@@ -363,7 +363,9 @@ bool FirstRun::SetShowFirstRunBubblePref(bool show_bubble) {
if (!local_state)
return false;
if (!local_state->FindPreference(prefs::kShouldShowFirstRunBubble)) {
- local_state->RegisterBooleanPref(prefs::kShouldShowFirstRunBubble, false);
+ local_state->RegisterBooleanPref(prefs::kShouldShowFirstRunBubble,
+ false,
+ false /* don't sync pref */);
local_state->SetBoolean(prefs::kShouldShowFirstRunBubble, show_bubble);
}
return true;
@@ -375,7 +377,9 @@ bool FirstRun::SetShowWelcomePagePref() {
if (!local_state)
return false;
if (!local_state->FindPreference(prefs::kShouldShowWelcomePage)) {
- local_state->RegisterBooleanPref(prefs::kShouldShowWelcomePage, false);
+ local_state->RegisterBooleanPref(prefs::kShouldShowWelcomePage,
+ false,
+ false /* don't sync pref */);
local_state->SetBoolean(prefs::kShouldShowWelcomePage, true);
}
return true;
@@ -389,7 +393,9 @@ bool FirstRun::SetPersonalDataManagerFirstRunPref() {
if (!local_state->FindPreference(
prefs::kAutofillPersonalDataManagerFirstRun)) {
local_state->RegisterBooleanPref(
- prefs::kAutofillPersonalDataManagerFirstRun, false);
+ prefs::kAutofillPersonalDataManagerFirstRun,
+ false,
+ false /* don't sync pref */);
local_state->SetBoolean(prefs::kAutofillPersonalDataManagerFirstRun, true);
}
return true;
@@ -402,7 +408,8 @@ bool FirstRun::SetOEMFirstRunBubblePref() {
return false;
if (!local_state->FindPreference(prefs::kShouldUseOEMFirstRunBubble)) {
local_state->RegisterBooleanPref(prefs::kShouldUseOEMFirstRunBubble,
- false);
+ false,
+ false /* don't sync pref */);
local_state->SetBoolean(prefs::kShouldUseOEMFirstRunBubble, true);
}
return true;
@@ -415,7 +422,8 @@ bool FirstRun::SetMinimalFirstRunBubblePref() {
return false;
if (!local_state->FindPreference(prefs::kShouldUseMinimalFirstRunBubble)) {
local_state->RegisterBooleanPref(prefs::kShouldUseMinimalFirstRunBubble,
- false);
+ false,
+ false /* don't sync pref */);
local_state->SetBoolean(prefs::kShouldUseMinimalFirstRunBubble, true);
}
return true;

Powered by Google App Engine
This is Rietveld 408576698