Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Unified Diff: chrome/browser/sync/glue/non_frontend_data_type_controller.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the previous fix Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/non_frontend_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/non_frontend_data_type_controller.cc b/chrome/browser/sync/glue/non_frontend_data_type_controller.cc
index d26baef48d17666eff2cd882bbc5d1010c6b9560..63a7572ece11b404b6b614b02902feabc06b8a33 100644
--- a/chrome/browser/sync/glue/non_frontend_data_type_controller.cc
+++ b/chrome/browser/sync/glue/non_frontend_data_type_controller.cc
@@ -194,7 +194,7 @@ void NonFrontendDataTypeController::Stop() {
// Deactivate the change processor on the UI thread. We dont want to listen
// for any more changes or process them from server.
- if (change_processor_ != NULL)
+ if (change_processor_.get())
profile_sync_service_->DeactivateDataType(this, change_processor_.get());
if (StopAssociationAsync()) {
@@ -215,10 +215,10 @@ void NonFrontendDataTypeController::StopModels() {
void NonFrontendDataTypeController::StopAssociation() {
DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (model_associator_ != NULL)
+ if (model_associator_.get())
model_associator_->DisassociateModels();
- change_processor_.reset();
model_associator_.reset();
+ change_processor_.reset();
datatype_stopped_.Signal();
}
@@ -266,6 +266,14 @@ void NonFrontendDataTypeController::set_state(State state) {
state_ = state;
}
+// TODO(zea)
+NewAssociatorInterface* NonFrontendDataTypeController::model_associator()
+ const {
+ NOTIMPLEMENTED();
+ return NULL;
+}
+
+// TODO(zea): switch to scoped_refptr usage.
void NonFrontendDataTypeController::set_model_associator(
AssociatorInterface* associator) {
model_associator_.reset(associator);

Powered by Google App Engine
This is Rietveld 408576698