chrome/browser/autofill/autofill_manager.cc - Issue 6905044: Refactor preference syncing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix the previous fix Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/about_flags_unittest.cc ('k') | chrome/browser/background_contents_service.cc » ('j') | chrome/browser/prefs/pref_model_associator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_manager.cc

diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc

index ea32437cd740f4707818cc6887590ed1786fff6e..49a0ec9742d2e67aa4a582772c5ea27b5eee747d 100644

--- a/chrome/browser/autofill/autofill_manager.cc

+++ b/chrome/browser/autofill/autofill_manager.cc

@@ -243,21 +243,30 @@ AutofillManager::~AutofillManager() {

// static

void AutofillManager::RegisterBrowserPrefs(PrefService* prefs) {

- prefs->RegisterDictionaryPref(prefs::kAutofillDialogPlacement);

+ prefs->RegisterDictionaryPref(prefs::kAutofillDialogPlacement,

+ false /* don't sync pref */);

}

// static

void AutofillManager::RegisterUserPrefs(PrefService* prefs) {

- prefs->RegisterBooleanPref(prefs::kAutofillEnabled, true);

+ prefs->RegisterBooleanPref(prefs::kAutofillEnabled,

+ true,

+ true /* sync pref */);

#if defined(OS_MACOSX)

- prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled, true);

+ prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled,

+ true,

+ true /* sync pref */);

#else

- prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled, false);

+ prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled,

+ false,

+ false /* don't sync pref */);

#endif

prefs->RegisterDoublePref(prefs::kAutofillPositiveUploadRate,

- kAutofillPositiveUploadRateDefaultValue);

+ kAutofillPositiveUploadRateDefaultValue,

+ false /* don't sync pref */);

prefs->RegisterDoublePref(prefs::kAutofillNegativeUploadRate,

- kAutofillNegativeUploadRateDefaultValue);

+ kAutofillNegativeUploadRateDefaultValue,

+ false /* don't sync pref */);

}

void AutofillManager::DidNavigateMainFramePostCommit(

« no previous file with comments | « chrome/browser/about_flags_unittest.cc ('k') | chrome/browser/background_contents_service.cc » ('j') | chrome/browser/prefs/pref_model_associator.h » ('J')