Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3961)

Unified Diff: chrome/browser/chromeos/user_cros_settings_provider.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/user_cros_settings_provider.cc
diff --git a/chrome/browser/chromeos/user_cros_settings_provider.cc b/chrome/browser/chromeos/user_cros_settings_provider.cc
index d0b9a4e33826f833965c976fc9a54ad1029e8a72..20038410814b8db813aa1aa2efa620a4556bd06f 100644
--- a/chrome/browser/chromeos/user_cros_settings_provider.cc
+++ b/chrome/browser/chromeos/user_cros_settings_provider.cc
@@ -76,17 +76,25 @@ bool IsControlledListSetting(const std::string& pref_path) {
void RegisterSetting(PrefService* local_state, const std::string& pref_path) {
local_state->RegisterBooleanPref((pref_path + kTrustedSuffix).c_str(),
- false);
+ false,
+ false /* don't sync pref */);
if (IsControlledBooleanSetting(pref_path)) {
if (pref_path == kSignedDataRoamingEnabled)
- local_state->RegisterBooleanPref(pref_path.c_str(), false);
+ local_state->RegisterBooleanPref(pref_path.c_str(),
+ false,
+ false /* don't sync pref */);
else
- local_state->RegisterBooleanPref(pref_path.c_str(), true);
+ local_state->RegisterBooleanPref(pref_path.c_str(),
+ true,
+ false /* don't sync pref */);
} else if (IsControlledStringSetting(pref_path)) {
- local_state->RegisterStringPref(pref_path.c_str(), "");
+ local_state->RegisterStringPref(pref_path.c_str(),
+ "",
+ false /* don't sync pref */);
} else {
DCHECK(IsControlledListSetting(pref_path));
- local_state->RegisterListPref(pref_path.c_str());
+ local_state->RegisterListPref(pref_path.c_str(),
+ false /* don't sync pref */);
}
}

Powered by Google App Engine
This is Rietveld 408576698