Refactor preference syncing.

chrome/browser/autofill/autofill_manager.cc

Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index ea32437cd740f4707818cc6887590ed1786fff6e..fb59b445d6451dabc23b99308f133eb80ff2320e 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -243,21 +243,30 @@ AutofillManager::~AutofillManager() {
 
 // static
 void AutofillManager::RegisterBrowserPrefs(PrefService* prefs) {
-  prefs->RegisterDictionaryPref(prefs::kAutofillDialogPlacement);
+  prefs->RegisterDictionaryPref(prefs::kAutofillDialogPlacement,
+                                false /* don't sync pref */);
 }
 
 // static
 void AutofillManager::RegisterUserPrefs(PrefService* prefs) {
-  prefs->RegisterBooleanPref(prefs::kAutofillEnabled, true);
+  prefs->RegisterBooleanPref(prefs::kAutofillEnabled,
+                             true,
+                             true /* sync pref */);
 #if defined(OS_MACOSX)
-  prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled, true);
+  prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled,

[dhollowa, 2011/04/27 14:01:16]

This should not be sync'd because it is not a cross-platform feature.  Setting
it to |true| on Windows or Linux will cause asserts to fire.  See
personal_data_manager.cc:618.

[Nicolas Zea, 2011/04/27 20:07:57]

Thanks for catching this. The model associator actually supports non-cross
platform preferences. They are simply dropped on the machine that doesn't
support them, as long as it doesn't register them as syncable.

Changed non-osx case to not register as syncable.

+                             true,
+                             true /* sync pref */);
 #else
-  prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled, false);
+  prefs->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled,
+                             false,
+                             true /* sync pref */);
 #endif
   prefs->RegisterDoublePref(prefs::kAutofillPositiveUploadRate,
-                            kAutofillPositiveUploadRateDefaultValue);
+                            kAutofillPositiveUploadRateDefaultValue,
+                            false /* don't sync pref */);
   prefs->RegisterDoublePref(prefs::kAutofillNegativeUploadRate,
-                            kAutofillNegativeUploadRateDefaultValue);
+                            kAutofillNegativeUploadRateDefaultValue,
+                            false /* don't sync pref */);
 }
 
 void AutofillManager::DidNavigateMainFramePostCommit(