Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2889)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + comments Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 43d6fa7215fdf17c82cbc5714b8c87a3158c1fb1..92e273bdba760dab8505f131a3615d8d82ccb67e 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -174,7 +174,9 @@ void MigrateBrowserPrefs(PrefService* user_prefs, PrefService* local_state) {
if ((current_version & WINDOWS_PREFS) == 0) {
// Migrate the devtools split location preference.
- local_state->RegisterIntegerPref(prefs::kDevToolsSplitLocation, -1);
+ local_state->RegisterIntegerPref(prefs::kDevToolsSplitLocation,
+ -1,
+ false /* don't sync pref */);
DCHECK(user_prefs->FindPreference(prefs::kDevToolsSplitLocation));
if (local_state->HasPrefPath(prefs::kDevToolsSplitLocation)) {
user_prefs->SetInteger(prefs::kDevToolsSplitLocation,
@@ -183,7 +185,8 @@ void MigrateBrowserPrefs(PrefService* user_prefs, PrefService* local_state) {
local_state->ClearPref(prefs::kDevToolsSplitLocation);
// Migrate the browser window placement preference.
- local_state->RegisterDictionaryPref(prefs::kBrowserWindowPlacement);
+ local_state->RegisterDictionaryPref(prefs::kBrowserWindowPlacement,
+ false /* don't sync pref */);
DCHECK(user_prefs->FindPreference(prefs::kBrowserWindowPlacement));
if (local_state->HasPrefPath(prefs::kBrowserWindowPlacement)) {
const PrefService::Preference* pref =

Powered by Google App Engine
This is Rietveld 408576698