Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4345)

Unified Diff: chrome/browser/browser_main.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + comments Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_main.cc
diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc
index 6224df9688887d062ea35df9cab23b681b387ac2..be99f0c20f52daa8e47fb634ad6d26f5b4e0cffa 100644
--- a/chrome/browser/browser_main.cc
+++ b/chrome/browser/browser_main.cc
@@ -745,15 +745,22 @@ PrefService* InitializeLocalState(const CommandLine& parsed_command_line,
// Initialize ResourceBundle which handles files loaded from external
// sources. This has to be done before uninstall code path and before prefs
// are registered.
- local_state->RegisterStringPref(prefs::kApplicationLocale, std::string());
+ local_state->RegisterStringPref(prefs::kApplicationLocale,
+ std::string(),
+ true /* sync pref */);
#if defined(OS_CHROMEOS)
- local_state->RegisterStringPref(prefs::kOwnerLocale, std::string());
+ local_state->RegisterStringPref(prefs::kOwnerLocale,
+ std::string(),
+ false /* don't sync pref */);
local_state->RegisterStringPref(prefs::kHardwareKeyboardLayout,
- std::string());
+ std::string(),
+ false /* don't sync pref */);
#endif // defined(OS_CHROMEOS)
#if !defined(OS_CHROMEOS)
- local_state->RegisterBooleanPref(prefs::kMetricsReportingEnabled,
- GoogleUpdateSettings::GetCollectStatsConsent());
+ local_state->RegisterBooleanPref(
+ prefs::kMetricsReportingEnabled,
+ GoogleUpdateSettings::GetCollectStatsConsent(),
+ false /* don't sync pref */);
#endif // !defined(OS_CHROMEOS)
if (is_first_run) {
@@ -785,7 +792,8 @@ PrefService* InitializeLocalState(const CommandLine& parsed_command_line,
scoped_ptr<PrefService> parent_local_state(
PrefService::CreatePrefService(parent_profile, NULL, NULL));
parent_local_state->RegisterStringPref(prefs::kApplicationLocale,
- std::string());
+ std::string(),
+ true /* sync pref */);
// Right now, we only inherit the locale setting from the parent profile.
local_state->SetString(
prefs::kApplicationLocale,

Powered by Google App Engine
This is Rietveld 408576698