Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8302)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 08879d1ed6ef6b3da9a272b7b56890f9135fbec3..6d9dd691e70e889601eef294dc6f6a3616b0415e 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -176,7 +176,9 @@ void MigrateBrowserPrefs(PrefService* user_prefs, PrefService* local_state) {
if ((current_version & WINDOWS_PREFS) == 0) {
// Migrate the devtools split location preference.
- local_state->RegisterIntegerPref(prefs::kDevToolsSplitLocation, -1);
+ local_state->RegisterIntegerPref(prefs::kDevToolsSplitLocation,
+ -1,
+ false /* don't sync pref */);
DCHECK(user_prefs->FindPreference(prefs::kDevToolsSplitLocation));
if (local_state->HasPrefPath(prefs::kDevToolsSplitLocation)) {
user_prefs->SetInteger(prefs::kDevToolsSplitLocation,
@@ -185,7 +187,8 @@ void MigrateBrowserPrefs(PrefService* user_prefs, PrefService* local_state) {
local_state->ClearPref(prefs::kDevToolsSplitLocation);
// Migrate the browser window placement preference.
- local_state->RegisterDictionaryPref(prefs::kBrowserWindowPlacement);
+ local_state->RegisterDictionaryPref(prefs::kBrowserWindowPlacement,
+ false /* don't sync pref */);
DCHECK(user_prefs->FindPreference(prefs::kBrowserWindowPlacement));
if (local_state->HasPrefPath(prefs::kBrowserWindowPlacement)) {
const PrefService::Preference* pref =

Powered by Google App Engine
This is Rietveld 408576698