Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/prefs/pref_set_observer_unittest.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix. And rebase Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_value_store.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/pref_set_observer.h" 5 #include "chrome/browser/prefs/pref_set_observer.h"
6 #include "chrome/common/pref_names.h" 6 #include "chrome/common/pref_names.h"
7 #include "chrome/test/testing_pref_service.h" 7 #include "chrome/test/testing_pref_service.h"
8 #include "content/common/notification_details.h" 8 #include "content/common/notification_details.h"
9 #include "content/common/notification_observer_mock.h" 9 #include "content/common/notification_observer_mock.h"
10 #include "content/common/notification_source.h" 10 #include "content/common/notification_source.h"
11 #include "testing/gmock/include/gmock/gmock.h" 11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 // Unit tests for PrefSetObserver. 14 // Unit tests for PrefSetObserver.
15 class PrefSetObserverTest : public testing::Test { 15 class PrefSetObserverTest : public testing::Test {
16 public: 16 public:
17 virtual void SetUp() { 17 virtual void SetUp() {
18 pref_service_.reset(new TestingPrefService); 18 pref_service_.reset(new TestingPrefService);
19 pref_service_->RegisterStringPref(prefs::kHomePage, "http://google.com"); 19 pref_service_->RegisterStringPref(prefs::kHomePage,
20 pref_service_->RegisterBooleanPref(prefs::kHomePageIsNewTabPage, false); 20 "http://google.com",
21 pref_service_->RegisterStringPref(prefs::kApplicationLocale, ""); 21 PrefService::UNSYNCABLE_PREF);
22 pref_service_->RegisterBooleanPref(prefs::kHomePageIsNewTabPage,
23 false,
24 PrefService::UNSYNCABLE_PREF);
25 pref_service_->RegisterStringPref(prefs::kApplicationLocale,
26 "",
27 PrefService::UNSYNCABLE_PREF);
22 } 28 }
23 29
24 PrefSetObserver* CreatePrefSetObserver(NotificationObserver* observer) { 30 PrefSetObserver* CreatePrefSetObserver(NotificationObserver* observer) {
25 PrefSetObserver* pref_set = 31 PrefSetObserver* pref_set =
26 new PrefSetObserver(pref_service_.get(), observer); 32 new PrefSetObserver(pref_service_.get(), observer);
27 pref_set->AddPref(prefs::kHomePage); 33 pref_set->AddPref(prefs::kHomePage);
28 pref_set->AddPref(prefs::kHomePageIsNewTabPage); 34 pref_set->AddPref(prefs::kHomePageIsNewTabPage);
29 return pref_set; 35 return pref_set;
30 } 36 }
31 37
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 PrefNameDetails(prefs::kHomePageIsNewTabPage))); 86 PrefNameDetails(prefs::kHomePageIsNewTabPage)));
81 pref_service_->SetUserPref(prefs::kHomePageIsNewTabPage, 87 pref_service_->SetUserPref(prefs::kHomePageIsNewTabPage,
82 Value::CreateBooleanValue(true)); 88 Value::CreateBooleanValue(true));
83 Mock::VerifyAndClearExpectations(&observer); 89 Mock::VerifyAndClearExpectations(&observer);
84 90
85 EXPECT_CALL(observer, Observe(_, _, _)).Times(0); 91 EXPECT_CALL(observer, Observe(_, _, _)).Times(0);
86 pref_service_->SetUserPref(prefs::kApplicationLocale, 92 pref_service_->SetUserPref(prefs::kApplicationLocale,
87 Value::CreateStringValue("en_US.utf8")); 93 Value::CreateStringValue("en_US.utf8"));
88 Mock::VerifyAndClearExpectations(&observer); 94 Mock::VerifyAndClearExpectations(&observer);
89 } 95 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_value_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698