Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Side by Side Diff: chrome/browser/extensions/apps_promo.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix. And rebase Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/apps_promo.h" 5 #include "chrome/browser/extensions/apps_promo.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/prefs/pref_service.h" 10 #include "chrome/browser/prefs/pref_service.h"
(...skipping 11 matching lines...) Expand all
22 local_state->RegisterStringPref(prefs::kNTPWebStorePromoHeader, empty); 22 local_state->RegisterStringPref(prefs::kNTPWebStorePromoHeader, empty);
23 local_state->RegisterStringPref(prefs::kNTPWebStorePromoButton, empty); 23 local_state->RegisterStringPref(prefs::kNTPWebStorePromoButton, empty);
24 local_state->RegisterStringPref(prefs::kNTPWebStorePromoLink, empty); 24 local_state->RegisterStringPref(prefs::kNTPWebStorePromoLink, empty);
25 local_state->RegisterStringPref(prefs::kNTPWebStorePromoExpire, empty); 25 local_state->RegisterStringPref(prefs::kNTPWebStorePromoExpire, empty);
26 } 26 }
27 27
28 // static 28 // static
29 void AppsPromo::RegisterUserPrefs(PrefService* prefs) { 29 void AppsPromo::RegisterUserPrefs(PrefService* prefs) {
30 // Set the default value for the counter to max+1 since we don't install 30 // Set the default value for the counter to max+1 since we don't install
31 // default apps for new users. 31 // default apps for new users.
32 prefs->RegisterIntegerPref( 32 prefs->RegisterIntegerPref(prefs::kAppsPromoCounter,
33 prefs::kAppsPromoCounter, kDefaultAppsCounterMax + 1); 33 kDefaultAppsCounterMax + 1,
34 prefs->RegisterBooleanPref(prefs::kDefaultAppsInstalled, false); 34 PrefService::UNSYNCABLE_PREF);
35 prefs->RegisterStringPref(prefs::kNTPWebStorePromoLastId, std::string()); 35 prefs->RegisterBooleanPref(prefs::kDefaultAppsInstalled,
36 false,
37 PrefService::UNSYNCABLE_PREF);
38 prefs->RegisterStringPref(prefs::kNTPWebStorePromoLastId,
39 std::string(),
40 PrefService::UNSYNCABLE_PREF);
36 } 41 }
37 42
38 // static 43 // static
39 void AppsPromo::ClearPromo() { 44 void AppsPromo::ClearPromo() {
40 PrefService* local_state = g_browser_process->local_state(); 45 PrefService* local_state = g_browser_process->local_state();
41 local_state->ClearPref(prefs::kNTPWebStorePromoId); 46 local_state->ClearPref(prefs::kNTPWebStorePromoId);
42 local_state->ClearPref(prefs::kNTPWebStorePromoHeader); 47 local_state->ClearPref(prefs::kNTPWebStorePromoHeader);
43 local_state->ClearPref(prefs::kNTPWebStorePromoButton); 48 local_state->ClearPref(prefs::kNTPWebStorePromoButton);
44 local_state->ClearPref(prefs::kNTPWebStorePromoLink); 49 local_state->ClearPref(prefs::kNTPWebStorePromoLink);
45 local_state->ClearPref(prefs::kNTPWebStorePromoExpire); 50 local_state->ClearPref(prefs::kNTPWebStorePromoExpire);
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 } 217 }
213 218
214 void AppsPromo::SetPromoCounter(int val) { 219 void AppsPromo::SetPromoCounter(int val) {
215 prefs_->SetInteger(prefs::kAppsPromoCounter, val); 220 prefs_->SetInteger(prefs::kAppsPromoCounter, val);
216 prefs_->ScheduleSavePersistentPrefs(); 221 prefs_->ScheduleSavePersistentPrefs();
217 } 222 }
218 223
219 bool AppsPromo::GetDefaultAppsInstalled() const { 224 bool AppsPromo::GetDefaultAppsInstalled() const {
220 return prefs_->GetBoolean(prefs::kDefaultAppsInstalled); 225 return prefs_->GetBoolean(prefs::kDefaultAppsInstalled);
221 } 226 }
OLDNEW
« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698