Refactor preference syncing.

chrome/browser/policy/managed_prefs_banner_base_unittest.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/managed_prefs_banner_base.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/testing_pref_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 // Tests whether managed preferences banner base functionality correctly
 // determines banner visiblity.
 class ManagedPrefsBannerBaseTest : public testing::Test {
  public:
   virtual void SetUp() {
     user_prefs_.reset(new TestingPrefService);
-    user_prefs_->RegisterBooleanPref(prefs::kHomePageIsNewTabPage, false);
-    user_prefs_->RegisterBooleanPref(prefs::kSearchSuggestEnabled, false);
+    user_prefs_->RegisterBooleanPref(prefs::kHomePageIsNewTabPage,
+                                     false,
+                                     true /* sync pref */);
+    user_prefs_->RegisterBooleanPref(prefs::kSearchSuggestEnabled,
+                                     false,
+                                     true /* sync pref */);
     local_state_.reset(new TestingPrefService);
-    local_state_->RegisterBooleanPref(prefs::kHomePageIsNewTabPage, false);
-    local_state_->RegisterBooleanPref(prefs::kMetricsReportingEnabled, false);
+    local_state_->RegisterBooleanPref(prefs::kHomePageIsNewTabPage,
+                                      false,
+                                      true /* sync pref */);
+    local_state_->RegisterBooleanPref(prefs::kMetricsReportingEnabled,
+                                      false,
+                                      false /* don't sync pref */);
   }
 
   scoped_ptr<TestingPrefService> local_state_;
   scoped_ptr<TestingPrefService> user_prefs_;
 };
 
 TEST_F(ManagedPrefsBannerBaseTest, VisibilityTest) {
   ManagedPrefsBannerBase banner(local_state_.get(),
                                 user_prefs_.get(),
                                 OPTIONS_PAGE_ADVANCED);
@@ skipping 40 matching lines @@
   user_prefs_->SetBoolean(prefs::kHomePageIsNewTabPage, true);
   EXPECT_CALL(banner, OnUpdateVisibility()).Times(1);
   user_prefs_->SetManagedPref(prefs::kSearchSuggestEnabled,
                               Value::CreateBooleanValue(false));
   EXPECT_CALL(banner, OnUpdateVisibility()).Times(1);
   local_state_->SetManagedPref(prefs::kMetricsReportingEnabled,
                                Value::CreateBooleanValue(true));
 }
 
 }  // namespace policy