Refactor preference syncing.

chrome/browser/web_resource/promo_resource_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/promo_resource_service.h"
 
 #include "base/string_number_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time.h"
 #include "base/values.h"
@@ skipping 38 matching lines @@
 
 }  // namespace
 
 // Server for dynamically loaded NTP HTML elements. TODO(mirandac): append
 // locale for future usage, when we're serving localizable strings.
 const char* PromoResourceService::kDefaultPromoResourceServer =
     "https://www.google.com/support/chrome/bin/topic/1142433/inproduct?hl=";
 
 // static
 void PromoResourceService::RegisterPrefs(PrefService* local_state) {
-  local_state->RegisterIntegerPref(prefs::kNTPPromoVersion, 0);
-  local_state->RegisterStringPref(prefs::kNTPPromoLocale, std::string());
+  local_state->RegisterIntegerPref(prefs::kNTPPromoVersion,
+                                   0,
+                                   false /* don't sync pref */);
+  local_state->RegisterStringPref(prefs::kNTPPromoLocale,
+                                  std::string(),
+                                  false /* don't sync pref */);
 }
 
 // static
 void PromoResourceService::RegisterUserPrefs(PrefService* prefs) {
-  prefs->RegisterDoublePref(prefs::kNTPCustomLogoStart, 0);
-  prefs->RegisterDoublePref(prefs::kNTPCustomLogoEnd, 0);
-  prefs->RegisterDoublePref(prefs::kNTPPromoStart, 0);
-  prefs->RegisterDoublePref(prefs::kNTPPromoEnd, 0);
-  prefs->RegisterStringPref(prefs::kNTPPromoLine, std::string());
-  prefs->RegisterBooleanPref(prefs::kNTPPromoClosed, false);
-  prefs->RegisterIntegerPref(prefs::kNTPPromoGroup, -1);
-  prefs->RegisterIntegerPref(prefs::kNTPPromoBuild,
-       CANARY_BUILD | DEV_BUILD | BETA_BUILD | STABLE_BUILD);
-  prefs->RegisterIntegerPref(prefs::kNTPPromoGroupTimeSlice, 0);
+  prefs->RegisterDoublePref(prefs::kNTPCustomLogoStart,
+                            0,
+                            false /* don't sync pref */);
+  prefs->RegisterDoublePref(prefs::kNTPCustomLogoEnd,
+                            0,
+                            false /* don't sync pref */);
+  prefs->RegisterDoublePref(prefs::kNTPPromoStart,
+                            0,
+                            false /* don't sync pref */);
+  prefs->RegisterDoublePref(prefs::kNTPPromoEnd,
+                            0,
+                            false /* don't sync pref */);
+  prefs->RegisterStringPref(prefs::kNTPPromoLine,
+                            std::string(),
+                            false /* don't sync pref */);
+  prefs->RegisterBooleanPref(prefs::kNTPPromoClosed,
+                             false,
+                             false /* don't sync pref */);
+  prefs->RegisterIntegerPref(prefs::kNTPPromoGroup,
+                             -1,
+                             false /* don't sync pref */);
+  prefs->RegisterIntegerPref(
+      prefs::kNTPPromoBuild,
+      CANARY_BUILD | DEV_BUILD | BETA_BUILD | STABLE_BUILD,
+      false /* don't sync pref */);
+  prefs->RegisterIntegerPref(prefs::kNTPPromoGroupTimeSlice,
+                             0,
+                             false /* don't sync pref */);
 }
 
 // static
 bool PromoResourceService::IsBuildTargeted(platform_util::Channel channel,
                                            int builds_allowed) {
   if (builds_allowed == NO_BUILD)
     return false;
   switch (channel) {
     case platform_util::CHANNEL_CANARY:
       return (CANARY_BUILD & builds_allowed) != 0;
@@ skipping 349 matching lines @@
     base::ThreadRestrictions::ScopedAllowIO allow_io;
     platform_util::Channel channel = platform_util::GetChannel();
     is_promo_build = PromoResourceService::IsBuildTargeted(
         channel, prefs->GetInteger(prefs::kNTPPromoBuild));
   }
 
   return !promo_closed && !is_synced && is_promo_build;
 }
 
 }  // namespace PromoResourceServiceUtil