Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/sync/profile_sync_factory_impl.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the previous fix Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/browser/extensions/extension_service.h" 6 #include "chrome/browser/extensions/extension_service.h"
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/browser/sync/glue/app_data_type_controller.h" 8 #include "chrome/browser/sync/glue/app_data_type_controller.h"
9 #include "chrome/browser/sync/glue/autofill_change_processor.h" 9 #include "chrome/browser/sync/glue/autofill_change_processor.h"
10 #include "chrome/browser/sync/glue/autofill_data_type_controller.h" 10 #include "chrome/browser/sync/glue/autofill_data_type_controller.h"
11 #include "chrome/browser/sync/glue/autofill_model_associator.h" 11 #include "chrome/browser/sync/glue/autofill_model_associator.h"
12 #include "chrome/browser/sync/glue/autofill_profile_change_processor.h" 12 #include "chrome/browser/sync/glue/autofill_profile_change_processor.h"
13 #include "chrome/browser/sync/glue/autofill_profile_data_type_controller.h" 13 #include "chrome/browser/sync/glue/autofill_profile_data_type_controller.h"
14 #include "chrome/browser/sync/glue/autofill_profile_model_associator.h" 14 #include "chrome/browser/sync/glue/autofill_profile_model_associator.h"
15 #include "chrome/browser/sync/glue/bookmark_change_processor.h" 15 #include "chrome/browser/sync/glue/bookmark_change_processor.h"
16 #include "chrome/browser/sync/glue/bookmark_data_type_controller.h" 16 #include "chrome/browser/sync/glue/bookmark_data_type_controller.h"
17 #include "chrome/browser/sync/glue/bookmark_model_associator.h" 17 #include "chrome/browser/sync/glue/bookmark_model_associator.h"
18 #include "chrome/browser/sync/glue/data_type_manager_impl.h" 18 #include "chrome/browser/sync/glue/data_type_manager_impl.h"
19 #include "chrome/browser/sync/glue/extension_change_processor.h" 19 #include "chrome/browser/sync/glue/extension_change_processor.h"
20 #include "chrome/browser/sync/glue/extension_data_type_controller.h" 20 #include "chrome/browser/sync/glue/extension_data_type_controller.h"
21 #include "chrome/browser/sync/glue/extension_model_associator.h" 21 #include "chrome/browser/sync/glue/extension_model_associator.h"
22 #include "chrome/browser/sync/glue/extension_sync_traits.h" 22 #include "chrome/browser/sync/glue/extension_sync_traits.h"
23 #include "chrome/browser/sync/glue/password_change_processor.h" 23 #include "chrome/browser/sync/glue/password_change_processor.h"
24 #include "chrome/browser/sync/glue/password_data_type_controller.h" 24 #include "chrome/browser/sync/glue/password_data_type_controller.h"
25 #include "chrome/browser/sync/glue/password_model_associator.h" 25 #include "chrome/browser/sync/glue/password_model_associator.h"
26 #include "chrome/browser/sync/glue/preference_change_processor.h"
27 #include "chrome/browser/sync/glue/preference_data_type_controller.h" 26 #include "chrome/browser/sync/glue/preference_data_type_controller.h"
28 #include "chrome/browser/sync/glue/preference_model_associator.h"
29 #include "chrome/browser/sync/glue/session_change_processor.h" 27 #include "chrome/browser/sync/glue/session_change_processor.h"
30 #include "chrome/browser/sync/glue/session_data_type_controller.h" 28 #include "chrome/browser/sync/glue/session_data_type_controller.h"
31 #include "chrome/browser/sync/glue/session_model_associator.h" 29 #include "chrome/browser/sync/glue/session_model_associator.h"
32 #include "chrome/browser/sync/glue/sync_backend_host.h" 30 #include "chrome/browser/sync/glue/sync_backend_host.h"
33 #include "chrome/browser/sync/glue/theme_change_processor.h" 31 #include "chrome/browser/sync/glue/theme_change_processor.h"
34 #include "chrome/browser/sync/glue/theme_data_type_controller.h" 32 #include "chrome/browser/sync/glue/theme_data_type_controller.h"
35 #include "chrome/browser/sync/glue/theme_model_associator.h" 33 #include "chrome/browser/sync/glue/theme_model_associator.h"
36 #include "chrome/browser/sync/glue/typed_url_change_processor.h" 34 #include "chrome/browser/sync/glue/typed_url_change_processor.h"
37 #include "chrome/browser/sync/glue/typed_url_data_type_controller.h" 35 #include "chrome/browser/sync/glue/typed_url_data_type_controller.h"
38 #include "chrome/browser/sync/glue/typed_url_model_associator.h" 36 #include "chrome/browser/sync/glue/typed_url_model_associator.h"
(...skipping 14 matching lines...) Expand all
53 using browser_sync::BookmarkModelAssociator; 51 using browser_sync::BookmarkModelAssociator;
54 using browser_sync::DataTypeController; 52 using browser_sync::DataTypeController;
55 using browser_sync::DataTypeManager; 53 using browser_sync::DataTypeManager;
56 using browser_sync::DataTypeManagerImpl; 54 using browser_sync::DataTypeManagerImpl;
57 using browser_sync::ExtensionChangeProcessor; 55 using browser_sync::ExtensionChangeProcessor;
58 using browser_sync::ExtensionDataTypeController; 56 using browser_sync::ExtensionDataTypeController;
59 using browser_sync::ExtensionModelAssociator; 57 using browser_sync::ExtensionModelAssociator;
60 using browser_sync::PasswordChangeProcessor; 58 using browser_sync::PasswordChangeProcessor;
61 using browser_sync::PasswordDataTypeController; 59 using browser_sync::PasswordDataTypeController;
62 using browser_sync::PasswordModelAssociator; 60 using browser_sync::PasswordModelAssociator;
63 using browser_sync::PreferenceChangeProcessor;
64 using browser_sync::PreferenceDataTypeController; 61 using browser_sync::PreferenceDataTypeController;
65 using browser_sync::PreferenceModelAssociator;
66 using browser_sync::SessionChangeProcessor; 62 using browser_sync::SessionChangeProcessor;
67 using browser_sync::SessionDataTypeController; 63 using browser_sync::SessionDataTypeController;
68 using browser_sync::SessionModelAssociator; 64 using browser_sync::SessionModelAssociator;
69 using browser_sync::SyncBackendHost; 65 using browser_sync::SyncBackendHost;
70 using browser_sync::ThemeChangeProcessor; 66 using browser_sync::ThemeChangeProcessor;
71 using browser_sync::ThemeDataTypeController; 67 using browser_sync::ThemeDataTypeController;
72 using browser_sync::ThemeModelAssociator; 68 using browser_sync::ThemeModelAssociator;
73 using browser_sync::TypedUrlChangeProcessor; 69 using browser_sync::TypedUrlChangeProcessor;
74 using browser_sync::TypedUrlDataTypeController; 70 using browser_sync::TypedUrlDataTypeController;
75 using browser_sync::TypedUrlModelAssociator; 71 using browser_sync::TypedUrlModelAssociator;
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 new PasswordModelAssociator(profile_sync_service, 258 new PasswordModelAssociator(profile_sync_service,
263 password_store); 259 password_store);
264 PasswordChangeProcessor* change_processor = 260 PasswordChangeProcessor* change_processor =
265 new PasswordChangeProcessor(model_associator, 261 new PasswordChangeProcessor(model_associator,
266 password_store, 262 password_store,
267 error_handler); 263 error_handler);
268 return SyncComponents(model_associator, change_processor); 264 return SyncComponents(model_associator, change_processor);
269 } 265 }
270 266
271 ProfileSyncFactory::SyncComponents 267 ProfileSyncFactory::SyncComponents
272 ProfileSyncFactoryImpl::CreatePreferenceSyncComponents(
273 ProfileSyncService* profile_sync_service,
274 UnrecoverableErrorHandler* error_handler) {
275 PreferenceModelAssociator* model_associator =
276 new PreferenceModelAssociator(profile_sync_service);
277 PreferenceChangeProcessor* change_processor =
278 new PreferenceChangeProcessor(model_associator,
279 error_handler);
280 return SyncComponents(model_associator, change_processor);
281 }
282
283 ProfileSyncFactory::SyncComponents
284 ProfileSyncFactoryImpl::CreateThemeSyncComponents( 268 ProfileSyncFactoryImpl::CreateThemeSyncComponents(
285 ProfileSyncService* profile_sync_service, 269 ProfileSyncService* profile_sync_service,
286 UnrecoverableErrorHandler* error_handler) { 270 UnrecoverableErrorHandler* error_handler) {
287 ThemeModelAssociator* model_associator = 271 ThemeModelAssociator* model_associator =
288 new ThemeModelAssociator(profile_sync_service); 272 new ThemeModelAssociator(profile_sync_service);
289 ThemeChangeProcessor* change_processor = 273 ThemeChangeProcessor* change_processor =
290 new ThemeChangeProcessor(error_handler); 274 new ThemeChangeProcessor(error_handler);
291 return SyncComponents(model_associator, change_processor); 275 return SyncComponents(model_associator, change_processor);
292 } 276 }
293 277
(...skipping 15 matching lines...) Expand all
309 ProfileSyncFactory::SyncComponents 293 ProfileSyncFactory::SyncComponents
310 ProfileSyncFactoryImpl::CreateSessionSyncComponents( 294 ProfileSyncFactoryImpl::CreateSessionSyncComponents(
311 ProfileSyncService* profile_sync_service, 295 ProfileSyncService* profile_sync_service,
312 UnrecoverableErrorHandler* error_handler) { 296 UnrecoverableErrorHandler* error_handler) {
313 SessionModelAssociator* model_associator = 297 SessionModelAssociator* model_associator =
314 new SessionModelAssociator(profile_sync_service); 298 new SessionModelAssociator(profile_sync_service);
315 SessionChangeProcessor* change_processor = 299 SessionChangeProcessor* change_processor =
316 new SessionChangeProcessor(error_handler, model_associator); 300 new SessionChangeProcessor(error_handler, model_associator);
317 return SyncComponents(model_associator, change_processor); 301 return SyncComponents(model_associator, change_processor);
318 } 302 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698