Refactor preference syncing.

chrome/browser/sync/glue/model_associator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_MODEL_ASSOCIATOR_H_
 #define CHROME_BROWSER_SYNC_GLUE_MODEL_ASSOCIATOR_H_
 #pragma once
 
 #include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/sync/engine/syncapi.h"
 #include "chrome/browser/sync/syncable/model_type.h"
 
-namespace sync_api {
-class BaseNode;
-}
+namespace browser_sync {
 
-namespace browser_sync {
+class ChangeProcessor;
 
 // This represents the fundamental operations used for model association that
 // are common to all ModelAssociators and do not depend on types of the models
 // being associated.
 class AssociatorInterface {
  public:
   virtual ~AssociatorInterface() {}
 
   // Iterates through both the sync and the chrome model looking for
   // matched pairs of items. After successful completion, the models
@@ skipping 51 matching lines @@
   virtual bool InitSyncNodeFromChromeId(const IDType& node_id,
                                         sync_api::BaseNode* sync_node) = 0;
 
   // Associates the given chrome node with the given sync id.
   virtual void Associate(const Node* node, int64 sync_id) = 0;
 
   // Remove the association that corresponds to the given sync id.
   virtual void Disassociate(int64 sync_id) = 0;
 };
 
+// TODO(zea): Have this replace the normal AssociatorInterface.
+class NewAssociatorInterface : public AssociatorInterface,
+                               public base::RefCounted<NewAssociatorInterface> {

[tim (not reviewing), 2011/04/28 21:51:44]

Why RefCounted?

[Nicolas Zea, 2011/05/03 18:59:36]

Done.

+ public:
+  // The model type of the associator.
+  virtual syncable::ModelType model_type() const {
+    return syncable::UNSPECIFIED;
+  }
+
+  // Sets the model associator's change processor. This is called by the
+  // ProfileSyncService and gives the associator an interface to the SyncApi.
+  virtual void set_change_processor(ChangeProcessor* processor) {}
+
+  // Returns the model associator's current change processor.
+  virtual ChangeProcessor* change_processor() { return NULL; }
+
+  // TODO(zea): Change the format of this to pass all specifics information
+  // in by reference.
+  virtual void ApplyChangesFromSync(
+      const sync_api::BaseTransaction* trans,
+      const sync_api::SyncManager::ChangeRecord* changes,
+      int change_count) {}
+ protected:
+  friend class base::RefCounted<NewAssociatorInterface>;
+
+  virtual ~NewAssociatorInterface() {}
+};
+
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_MODEL_ASSOCIATOR_H_