Refactor preference syncing.

chrome/browser/first_run/first_run.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/first_run.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
@@ skipping 345 matching lines @@
     return false;
   return file_util::WriteFile(first_run_sentinel, "", 0) != -1;
 }
 
 // static
 bool FirstRun::SetShowFirstRunBubblePref(bool show_bubble) {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(prefs::kShouldShowFirstRunBubble)) {
-    local_state->RegisterBooleanPref(prefs::kShouldShowFirstRunBubble, false);
+    local_state->RegisterBooleanPref(prefs::kShouldShowFirstRunBubble,
+                                     false,
+                                     false /* don't sync pref */);
     local_state->SetBoolean(prefs::kShouldShowFirstRunBubble, show_bubble);
   }
   return true;
 }
 
 // static
 bool FirstRun::SetShowWelcomePagePref() {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(prefs::kShouldShowWelcomePage)) {
-    local_state->RegisterBooleanPref(prefs::kShouldShowWelcomePage, false);
+    local_state->RegisterBooleanPref(prefs::kShouldShowWelcomePage,
+                                     false,
+                                     false /* don't sync pref */);
     local_state->SetBoolean(prefs::kShouldShowWelcomePage, true);
   }
   return true;
 }
 
 // static
 bool FirstRun::SetPersonalDataManagerFirstRunPref() {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(
           prefs::kAutofillPersonalDataManagerFirstRun)) {
     local_state->RegisterBooleanPref(
-        prefs::kAutofillPersonalDataManagerFirstRun, false);
+        prefs::kAutofillPersonalDataManagerFirstRun,
+        false,
+        false /* don't sync pref */);
     local_state->SetBoolean(prefs::kAutofillPersonalDataManagerFirstRun, true);
   }
   return true;
 }
 
 // static
 bool FirstRun::SearchEngineSelectorDisallowed() {
   // For now, the only case in which the search engine dialog should never be
   // shown is if the locale is Russia.
   std::string locale = g_browser_process->GetApplicationLocale();
   return (locale == "ru");
 }
 
 // static
 bool FirstRun::SetOEMFirstRunBubblePref() {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(prefs::kShouldUseOEMFirstRunBubble)) {
     local_state->RegisterBooleanPref(prefs::kShouldUseOEMFirstRunBubble,
-                                     false);
+                                     false,
+                                     false /* don't sync pref */);
     local_state->SetBoolean(prefs::kShouldUseOEMFirstRunBubble, true);
   }
   return true;
 }
 
 // static
 bool FirstRun::SetMinimalFirstRunBubblePref() {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(prefs::kShouldUseMinimalFirstRunBubble)) {
     local_state->RegisterBooleanPref(prefs::kShouldUseMinimalFirstRunBubble,
-                                     false);
+                                     false,
+                                     false /* don't sync pref */);
     local_state->SetBoolean(prefs::kShouldUseMinimalFirstRunBubble, true);
   }
   return true;
 }
 
 // static
 int FirstRun::ImportFromFile(Profile* profile, const CommandLine& cmdline) {
   FilePath file_path = cmdline.GetSwitchValuePath(switches::kImportFromFile);
   if (file_path.empty()) {
     NOTREACHED();
@@ skipping 210 matching lines @@
   if (!observer->ended()) {
     observer->set_should_quit_message_loop();
     MessageLoop::current()->Run();
   }
 
   // Unfortunately there's no success/fail signal in ImporterHost.
   return true;
 }
 
 #endif  // OS_POSIX