Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: chrome/browser/extensions/apps_promo.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/apps_promo.h" 5 #include "chrome/browser/extensions/apps_promo.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/prefs/pref_service.h" 10 #include "chrome/browser/prefs/pref_service.h"
11 #include "chrome/browser/ui/webui/ntp/shown_sections_handler.h" 11 #include "chrome/browser/ui/webui/ntp/shown_sections_handler.h"
12 #include "chrome/common/chrome_switches.h" 12 #include "chrome/common/chrome_switches.h"
13 #include "chrome/common/extensions/extension.h" 13 #include "chrome/common/extensions/extension.h"
14 #include "chrome/common/pref_names.h" 14 #include "chrome/common/pref_names.h"
15 15
16 const int AppsPromo::kDefaultAppsCounterMax = 10; 16 const int AppsPromo::kDefaultAppsCounterMax = 10;
17 17
18 // static 18 // static
19 void AppsPromo::RegisterPrefs(PrefService* local_state) { 19 void AppsPromo::RegisterPrefs(PrefService* local_state) {
20 std::string empty; 20 std::string empty;
21 local_state->RegisterStringPref(prefs::kNTPWebStorePromoId, empty); 21 local_state->RegisterStringPref(prefs::kNTPWebStorePromoId,
22 local_state->RegisterStringPref(prefs::kNTPWebStorePromoHeader, empty); 22 empty,
23 local_state->RegisterStringPref(prefs::kNTPWebStorePromoButton, empty); 23 false /* don't sync pref */);
24 local_state->RegisterStringPref(prefs::kNTPWebStorePromoLink, empty); 24 local_state->RegisterStringPref(prefs::kNTPWebStorePromoHeader,
25 local_state->RegisterStringPref(prefs::kNTPWebStorePromoExpire, empty); 25 empty,
26 false /* don't sync pref */);
27 local_state->RegisterStringPref(prefs::kNTPWebStorePromoButton,
28 empty,
29 false /* don't sync pref */);
30 local_state->RegisterStringPref(prefs::kNTPWebStorePromoLink,
31 empty,
32 false /* don't sync pref */);
33 local_state->RegisterStringPref(prefs::kNTPWebStorePromoExpire,
34 empty,
35 false /* don't sync pref */);
26 } 36 }
27 37
28 // static 38 // static
29 void AppsPromo::RegisterUserPrefs(PrefService* prefs) { 39 void AppsPromo::RegisterUserPrefs(PrefService* prefs) {
30 // Set the default value for the counter to max+1 since we don't install 40 // Set the default value for the counter to max+1 since we don't install
31 // default apps for new users. 41 // default apps for new users.
32 prefs->RegisterIntegerPref( 42 prefs->RegisterIntegerPref(prefs::kAppsPromoCounter,
33 prefs::kAppsPromoCounter, kDefaultAppsCounterMax + 1); 43 kDefaultAppsCounterMax + 1,
34 prefs->RegisterBooleanPref(prefs::kDefaultAppsInstalled, false); 44 false /* don't sync pref */);
35 prefs->RegisterStringPref(prefs::kNTPWebStorePromoLastId, std::string()); 45 prefs->RegisterBooleanPref(prefs::kDefaultAppsInstalled,
46 false,
47 false /* don't sync pref */);
48 prefs->RegisterStringPref(prefs::kNTPWebStorePromoLastId,
49 std::string(),
50 false /* don't sync pref */);
36 } 51 }
37 52
38 // static 53 // static
39 void AppsPromo::ClearPromo() { 54 void AppsPromo::ClearPromo() {
40 PrefService* local_state = g_browser_process->local_state(); 55 PrefService* local_state = g_browser_process->local_state();
41 local_state->ClearPref(prefs::kNTPWebStorePromoId); 56 local_state->ClearPref(prefs::kNTPWebStorePromoId);
42 local_state->ClearPref(prefs::kNTPWebStorePromoHeader); 57 local_state->ClearPref(prefs::kNTPWebStorePromoHeader);
43 local_state->ClearPref(prefs::kNTPWebStorePromoButton); 58 local_state->ClearPref(prefs::kNTPWebStorePromoButton);
44 local_state->ClearPref(prefs::kNTPWebStorePromoLink); 59 local_state->ClearPref(prefs::kNTPWebStorePromoLink);
45 local_state->ClearPref(prefs::kNTPWebStorePromoExpire); 60 local_state->ClearPref(prefs::kNTPWebStorePromoExpire);
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 } 227 }
213 228
214 void AppsPromo::SetPromoCounter(int val) { 229 void AppsPromo::SetPromoCounter(int val) {
215 prefs_->SetInteger(prefs::kAppsPromoCounter, val); 230 prefs_->SetInteger(prefs::kAppsPromoCounter, val);
216 prefs_->ScheduleSavePersistentPrefs(); 231 prefs_->ScheduleSavePersistentPrefs();
217 } 232 }
218 233
219 bool AppsPromo::GetDefaultAppsInstalled() const { 234 bool AppsPromo::GetDefaultAppsInstalled() const {
220 return prefs_->GetBoolean(prefs::kDefaultAppsInstalled); 235 return prefs_->GetBoolean(prefs::kDefaultAppsInstalled);
221 } 236 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698