Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/browser/notifications/notification_ui_manager.cc

Issue 6905044: Refactor preference syncing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/notification_ui_manager.h" 5 #include "chrome/browser/notifications/notification_ui_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/stl_util-inl.h" 9 #include "base/stl_util-inl.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 BalloonCollection* balloons = BalloonCollection::Create(); 70 BalloonCollection* balloons = BalloonCollection::Create();
71 NotificationUIManager* instance = new NotificationUIManager(local_state); 71 NotificationUIManager* instance = new NotificationUIManager(local_state);
72 instance->Initialize(balloons); 72 instance->Initialize(balloons);
73 balloons->set_space_change_listener(instance); 73 balloons->set_space_change_listener(instance);
74 return instance; 74 return instance;
75 } 75 }
76 76
77 // static 77 // static
78 void NotificationUIManager::RegisterPrefs(PrefService* prefs) { 78 void NotificationUIManager::RegisterPrefs(PrefService* prefs) {
79 prefs->RegisterIntegerPref(prefs::kDesktopNotificationPosition, 79 prefs->RegisterIntegerPref(prefs::kDesktopNotificationPosition,
80 BalloonCollection::DEFAULT_POSITION); 80 BalloonCollection::DEFAULT_POSITION,
81 false /* don't sync pref */);
81 } 82 }
82 83
83 void NotificationUIManager::Initialize( 84 void NotificationUIManager::Initialize(
84 BalloonCollection* balloon_collection) { 85 BalloonCollection* balloon_collection) {
85 DCHECK(!balloon_collection_.get()); 86 DCHECK(!balloon_collection_.get());
86 DCHECK(balloon_collection); 87 DCHECK(balloon_collection);
87 balloon_collection_.reset(balloon_collection); 88 balloon_collection_.reset(balloon_collection);
88 balloon_collection_->SetPositionPreference( 89 balloon_collection_->SetPositionPreference(
89 static_cast<BalloonCollection::PositionPreference>( 90 static_cast<BalloonCollection::PositionPreference>(
90 position_pref_.GetValue())); 91 position_pref_.GetValue()));
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 } else if (type == NotificationType::PREF_CHANGED) { 235 } else if (type == NotificationType::PREF_CHANGED) {
235 std::string* name = Details<std::string>(details).ptr(); 236 std::string* name = Details<std::string>(details).ptr();
236 if (*name == prefs::kDesktopNotificationPosition) 237 if (*name == prefs::kDesktopNotificationPosition)
237 balloon_collection_->SetPositionPreference( 238 balloon_collection_->SetPositionPreference(
238 static_cast<BalloonCollection::PositionPreference>( 239 static_cast<BalloonCollection::PositionPreference>(
239 position_pref_.GetValue())); 240 position_pref_.GetValue()));
240 } else { 241 } else {
241 NOTREACHED(); 242 NOTREACHED();
242 } 243 }
243 } 244 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698