Refactor preference syncing.

chrome/browser/metrics/metrics_service_uitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests the MetricsService stat recording to make sure that the numbers are
 // what we expect.
 
 #include <string>
 
 #include "base/file_path.h"
@@ skipping 44 matching lines @@
     FilePath path = user_data_dir().Append(chrome::kLocalStateFilename);
     return PrefServiceMockBuilder().WithUserFilePrefs(path).Create();
   }
 };
 
 TEST_F(MetricsServiceTest, CloseRenderersNormally) {
   OpenTabs();
   QuitBrowser();
 
   scoped_ptr<PrefService> local_state(GetLocalState());
-  local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly, true);
-  local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount, 0);
-  local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount, 0);
-  local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount, 0);
+  local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly,
+                                   true,
+                                   false /* don't sync pref */);
+  local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount,
+                                   0,
+                                   false /* don't sync pref */);
+  local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount,
+                                   0,
+                                   false /* don't sync pref */);
+  local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount,
+                                   0,
+                                   false /* don't sync pref */);
   EXPECT_TRUE(local_state->GetBoolean(prefs::kStabilityExitedCleanly));
   EXPECT_EQ(1, local_state->GetInteger(prefs::kStabilityLaunchCount));
   EXPECT_EQ(3, local_state->GetInteger(prefs::kStabilityPageLoadCount));
   EXPECT_EQ(0, local_state->GetInteger(prefs::kStabilityRendererCrashCount));
 }
 
 TEST_F(MetricsServiceTest, DISABLED_CrashRenderers) {
   // This doesn't make sense to test in single process mode.
   if (ProxyLauncher::in_process_renderer())
     return;
@@ skipping 19 matching lines @@
 #endif
     ASSERT_TRUE(tab->NavigateToURLAsync(GURL(chrome::kAboutCrashURL)));
   }
 
   // Give the browser a chance to notice the crashed tab.
   base::PlatformThread::Sleep(TestTimeouts::action_timeout_ms());
 
   QuitBrowser();
 
   scoped_ptr<PrefService> local_state(GetLocalState());
-  local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly, true);
-  local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount, 0);
-  local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount, 0);
-  local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount, 0);
+  local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly,
+                                   true,
+                                   false /* don't sync pref */);
+  local_state->RegisterIntegerPref(prefs::kStabilityLaunchCount,
+                                   0,
+                                   false /* don't sync pref */);
+  local_state->RegisterIntegerPref(prefs::kStabilityPageLoadCount,
+                                   0,
+                                   false /* don't sync pref */);
+  local_state->RegisterIntegerPref(prefs::kStabilityRendererCrashCount,
+                                   0,
+                                   false /* don't sync pref */);
   EXPECT_TRUE(local_state->GetBoolean(prefs::kStabilityExitedCleanly));
   EXPECT_EQ(1, local_state->GetInteger(prefs::kStabilityLaunchCount));
   EXPECT_EQ(4, local_state->GetInteger(prefs::kStabilityPageLoadCount));
   EXPECT_EQ(1, local_state->GetInteger(prefs::kStabilityRendererCrashCount));
 }