src/runtime.cc - Issue 6905035: Fix raw pointer misuse in StringReplaceRegExpWithEmptyString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 6905035: Fix raw pointer misuse in StringReplaceRegExpWithEmptyString. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index d8aaf718097616ae83cc35fa1e9d56121774ea48..ff0503718b5c93262a33eda9f7ab8d24a6d379a4 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -2713,7 +2713,7 @@ MUST_USE_RESULT static MaybeObject* StringReplaceRegExpWithEmptyString(

end = RegExpImpl::GetCapture(match_info_array, 1);

}

- int length = subject->length();

+ int length = subject_handle->length();

int new_length = length - (end - start);

if (new_length == 0) {

return isolate->heap()->empty_string();

« no previous file with comments | « no previous file | no next file » | no next file with comments »