Implement new gray mock.

Implement new gray mock.

BUG=chromium-os:14276
TEST=Login, examine both regular and OTR, and test with and without themes.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83729

[sky, 2011-05-02 14:26:27]

LGTM with the following changes

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
File chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc:24: //
BrowserFrameViewChromeos adds some a few pixels of pad to the top of the
remove some

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc:36: int
BrowserFrameViewChromeos::GetHorizontalTabStripVerticalOffset(
order doesn't match header.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc:53: views::View*
BrowserFrameViewChromeos::GetEventHandlerForPoint(const gfx::Point& point) {
> 80

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
File chrome/browser/chromeos/frame/browser_frame_view_chromeos.h (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.h:21: virtual
views::View* GetEventHandlerForPoint(const gfx::Point& point)
wrap at const so that last param and OVERRIDE on on the same line.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_frame_view_chromeos.h:28: int* top_offset,
SkBitmap** left_corner, SkBitmap** right_corner)
each param on its own line.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
File
chrome/browser/chromeos/frame/browser_non_client_frame_view_factory_chromeos.cc
(right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_non_client_frame_view_factory_chromeos.cc:8:
#include "chrome/browser/chromeos/frame/browser_frame_view_chromeos.h"
sort

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
File chrome/browser/chromeos/frame/browser_view.cc (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/frame...
chrome/browser/chromeos/frame/browser_view.cc:401: StatusAreaHost::kWhiteHaloed
: IsOffTheRecord() ?
Oi. Can you use () around the first conditional to this a bit more readable.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
File chrome/browser/chromeos/status/status_area_button.cc (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
chrome/browser/chromeos/status/status_area_button.cc:33: menu_delegate, false),
indent to make clear part of MenuButton.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
File chrome/browser/chromeos/status/status_area_button.h (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
chrome/browser/chromeos/status/status_area_button.h:20: StatusAreaHost* host,
views::ViewMenuDelegate* menu_delegate);
each param on its own line.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
chrome/browser/chromeos/status/status_area_button.h:45: 
no newline here.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
File chrome/browser/chromeos/status/status_area_host.h (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/chromeos/statu...
chrome/browser/chromeos/status/status_area_host.h:42: enum TextStyle {
enums should be first in a section.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view.cc:708: DCHECK(left &&
right);
The DCHECK and if don't match.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view.h (left):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view.h:97: int
NonClientTopBorderHeight(bool restored, bool ignore_vertical_tabs) const;
move implementation to match new position in header.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view.h (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view.h:78: // Returns the
height of the entire nonclient top border, including the window
Most these before other overrides in the section.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view.h:89: int* theme_offset,
SkBitmap** left_corner, SkBitmap** right_corner);
each param on its own line. Also, document what this does.

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/tab.cc (right):

http://codereview.chromium.org/6904160/diff/167/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:473: //  bg_offset_y = 0;
Nuke this.

http://codereview.chromium.org/6904160/diff/167/views/controls/button/text_bu...
File views/controls/button/text_button.cc (right):

http://codereview.chromium.org/6904160/diff/167/views/controls/button/text_bu...
views/controls/button/text_button.cc:334: shadow_offset_ = gfx::Point(x, y);
SetPoint

http://codereview.chromium.org/6904160/diff/167/views/window/non_client_view.h
File views/window/non_client_view.h (right):

http://codereview.chromium.org/6904160/diff/167/views/window/non_client_view....
views/window/non_client_view.h:221: virtual views::View*
GetEventHandlerForPoint(const gfx::Point& point)
Move implementation to match new position.