Issue 6904152: Complete apply_issue.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6904152: Complete apply_issue.py. (Closed)

Created:
9 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Complete apply_issue.py. This is to be able to apply patches directly from rietveld for the try server. TEST=tested on both svn and git with binary files. unit tests will follow up. R=dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84255

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -10 lines)			Patch
	M	apply_issue.py	View		3 chunks	+20 lines, -3 lines	1 comment	Download
	M	checkout.py	View		4 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 7 months ago (2011-05-02 20:32:04 UTC) #2

LGTM.

http://codereview.chromium.org/6904152/diff/1/apply_issue.py
File apply_issue.py (right):

http://codereview.chromium.org/6904152/diff/1/apply_issue.py#newcode62
apply_issue.py:62: scm_type = scm.determine_scm(options.root_dir)
Nit ... seems like this block could be turned into a factory function that
returned an object directly, and that such a function would be generally useful.

Expand Messages | Collapse Messages