Issue 6904124: ARM: Fix handling of return value of compare_doubles in the simulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6904124: ARM: Fix handling of return value of compare_doubles in the simulator. (Closed)

Created:
9 years, 8 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Fix handling of return value of compare_doubles in the simulator.

Patch Set 2 : Address comment. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	src/arm/simulator-arm.cc	View	1	3 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6904124/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/6904124/diff/1/src/arm/simulator-arm.cc#newcode1788 src/arm/simulator-arm.cc:1788: FUNCTION_ADDR(target), dval1); dval1 -> dval0

9 years, 7 months ago (2011-04-29 11:01:58 UTC) #2

Karl Klose

9 years, 7 months ago (2011-04-29 11:14:34 UTC) #3

http://codereview.chromium.org/6904124/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/6904124/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:1788: FUNCTION_ADDR(target), dval1);
On 2011/04/29 11:01:58, Søren Gjesse wrote:
> dval1 -> dval0

Done.

Expand Messages | Collapse Messages

Issue 6904124: ARM: Fix handling of return value of compare_doubles in the simulator. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages