Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: base/logging.h

Issue 6904109: linux: components support for base/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util.h ('k') | base/message_pump_libevent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index 1d094e3cbdd04327ac500e5bf530ff2b25b42d2d..54d6dfd00a329e52b721bb3aeea88d78de8dc83d 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -468,7 +468,7 @@ std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
}
// MSVC doesn't like complex extern templates and DLLs.
-#if !defined(COMPILER_MSVC)
+#if !defined(COMPILER_MSVC) && defined(BASE_DLL)
// Commonly used instantiations of MakeCheckOpString<>. Explicitly instantiated
// in logging.cc.
extern template std::string* MakeCheckOpString<int, int>(
@@ -842,7 +842,7 @@ class BASE_API Win32ErrorLogMessage {
};
#elif defined(OS_POSIX)
// Appends a formatted system message of the errno type
-class ErrnoLogMessage {
+class BASE_API ErrnoLogMessage {
public:
ErrnoLogMessage(const char* file,
int line,
« no previous file with comments | « base/file_util.h ('k') | base/message_pump_libevent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698