linux: components support for base/

base/synchronization/lock_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SYNCHRONIZATION_LOCK_IMPL_H_
 #define BASE_SYNCHRONIZATION_LOCK_IMPL_H_
 #pragma once
 
+#include "base/base_api.h"
+#include "base/basictypes.h"

[rvargas (doing something else), 2011/04/28 23:29:43]

I think we still want these to go after the os dependent block given that
<windows.h> is included there. Granted, there should not be an issue with what
we have here, but the next chromium include added may have issues.

[Evan Martin, 2011/04/28 23:39:40]

There was some thread on chromium-dev where we decided to always put these
before OS-specific headers, so I think we're ok, but I changed it back just in
case because this isn't relevant to my change.

[rvargas (doing something else), 2011/04/28 23:45:31]

Yes, that same thread mentioned this exception (although it is not in the style
guide :( ).

 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #elif defined(OS_POSIX)
 #include <pthread.h>
 #endif
 
-#include "base/basictypes.h"
-
 namespace base {
 namespace internal {
 
 // This class implements the underlying platform-specific spin-lock mechanism
 // used for the Lock class.  Most users should not use LockImpl directly, but
 // should instead use Lock.
-class LockImpl {
+class BASE_API LockImpl {

[rvargas (doing something else), 2011/04/28 23:29:43]

Why do we need to export this? It should not be used outside base.

[Evan Martin, 2011/04/28 23:39:40]

Lock::~Lock() is inlined, and it calls LockImpl::~LockImpl.


/work/chrome/bin/ld: ninja/obj/base_unittests/base/observer_list_unittest.o: in
function base::Lock::~Lock():./base/synchronization/lock.h:36: error: undefined
reference to 'base::internal::LockImpl::~LockImpl()'

  public:
 #if defined(OS_WIN)
   typedef CRITICAL_SECTION OSLockType;
 #elif defined(OS_POSIX)
   typedef pthread_mutex_t OSLockType;
 #endif
 
   LockImpl();
   ~LockImpl();
 
@@ skipping 18 matching lines @@
  private:
   OSLockType os_lock_;
 
   DISALLOW_COPY_AND_ASSIGN(LockImpl);
 };
 
 }  // namespace internal
 }  // namespace base
 
 #endif  // BASE_SYNCHRONIZATION_LOCK_IMPL_H_