linux: components support for base/

base/base.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'base_target': 0,
     },
     'target_conditions': [
@@ skipping 510 matching lines @@
               'third_party/purify/pure_api.c',
               'base_drag_source.cc',
               'base_drop_target.cc',
               'event_recorder.cc',
               'file_version_info.cc',
               'registry.cc',
               'resource_util.cc',
               'win_util.cc',
             ],
         },],
-        [ 'OS=="win" and component=="shared_library"', {
+        [ 'component=="shared_library"', {
           'defines': [
             'BASE_DLL',
             'BASE_IMPLEMENTATION=1',
           ],
-          'msvs_disabled_warnings': [
-            4251,
+          'conditions': [
+            ['OS=="win"', {
+              'msvs_disabled_warnings': [
+                4251,
+              ],
+              'sources!': [
+                'debug/debug_on_start_win.cc',
+              ],
+              'direct_dependent_settings': {

[Lei Zhang, 2011/04/28 23:21:45]

Do we need to propagate the BASE_DLL define for OS!="win" ?

[Evan Martin, 2011/04/28 23:24:52]

No, it's used for dllimport on Win but it doesn't do anything on non-Win.

+                'defines': [
+                  'BASE_DLL',
+                ],
+                'msvs_disabled_warnings': [
+                  4251,
+                ],
+              },
+            }],
           ],
-          'sources!': [
-            'debug/debug_on_start_win.cc',
-          ],
-          'direct_dependent_settings': {
-            'defines': [
-              'BASE_DLL',
-            ],
-            'msvs_disabled_warnings': [
-              4251,
-            ],
-          },
         }],
       ],
       'sources': [
         'third_party/nspr/prcpucfg.h',
         'third_party/nspr/prcpucfg_win.h',
         'third_party/nspr/prtypes.h',
         'third_party/purify/pure.h',
         'third_party/purify/pure_api.c',
         'third_party/xdg_user_dirs/xdg_user_dir_lookup.cc',
         'third_party/xdg_user_dirs/xdg_user_dir_lookup.h',
@@ skipping 117 matching lines @@
             'third_party/xdg_mime/xdgmimemagic.c',
             'third_party/xdg_mime/xdgmimemagic.h',
             'third_party/xdg_mime/xdgmimeparent.c',
             'third_party/xdg_mime/xdgmimeparent.h',
           ],
         },
       ],
     }],
   ],
 }