Issue 6904055: Profile user data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6904055: Profile user data. (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
cmp, chase

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Send googler profiling data. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83507

Patch Set 5 : addressed review comments (and used python2.6 to upload) #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -11 lines)			Patch
	M	breakpad.py	View	1 2 3 4	3 chunks	+41 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cmp

http://codereview.chromium.org/6904055/diff/2001/breakpad.py File breakpad.py (right): http://codereview.chromium.org/6904055/diff/2001/breakpad.py#newcode92 breakpad.py:92: 'duration': time.time() - _TIME_STARTED, please add 'os' here (result ...

9 years, 8 months ago (2011-04-27 21:30:05 UTC) #2

M-A Ruel

Added timeout, only works on python 2.6. Added platform.

9 years, 8 months ago (2011-04-28 01:27:05 UTC) #3

cmp

9 years, 8 months ago (2011-04-28 02:00:24 UTC) #4

lgtm with nits

http://codereview.chromium.org/6904055/diff/1002/breakpad.py
File breakpad.py (right):

http://codereview.chromium.org/6904055/diff/1002/breakpad.py#newcode23
breakpad.py:23: import sys
reorder these alphabetically

http://codereview.chromium.org/6904055/diff/1002/breakpad.py#newcode37
breakpad.py:37: if (sys.version_info[0] * 10 + sys.version_info[1])  >= 26:
remove extra space after )

http://codereview.chromium.org/6904055/diff/1002/breakpad.py#newcode103
breakpad.py:103: 'duration': time.time() - _TIME_STARTED,
move line 103 above line 102

Expand Messages | Collapse Messages

Issue 6904055: Profile user data. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : improvements #

Patch Set 4 : . #

Patch Set 5 : addressed review comments (and used python2.6 to upload) #

Messages