Remove ibus checking script from views.gyp and add use_ibus=1 option

Remove ibus checking script from views.gyp and add use_ibus=1 option


BUG=chromium:80700
TEST=Test it on Linux desktop


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83232

[agl, 2011-04-27 18:39:17]

LGTM

[Paweł Hajdan Jr., 2011-04-27 19:06:04]

Drive-by with a suggestion. Thank you for producing a fix, it's much better
anyway.

http://codereview.chromium.org/6904053/diff/3001/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/6904053/diff/3001/views/views.gyp#newcode439
views/views.gyp:439: 'defines' : ['HAVE_IBUS=1'],
I think it's generally more maintainable to have 'defines': ['HAVE_IBUS=1'] in
direct_dependent_settings in system.gyp:ibus instead of here.

[Peng, 2011-04-27 19:41:16]

http://codereview.chromium.org/6904053/diff/3001/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/6904053/diff/3001/views/views.gyp#newcode439
views/views.gyp:439: 'defines' : ['HAVE_IBUS=1'],
On 2011/04/27 19:06:05, Paweł Hajdan Jr. wrote:
> I think it's generally more maintainable to have 'defines': ['HAVE_IBUS=1'] in
> direct_dependent_settings in system.gyp:ibus instead of here.

Done.

[Paweł Hajdan Jr., 2011-04-27 19:53:36]

Code I commented in the drive-by LGTM with a nit. Thanks!

http://codereview.chromium.org/6904053/diff/3002/build/linux/system.gyp
File build/linux/system.gyp (right):

http://codereview.chromium.org/6904053/diff/3002/build/linux/system.gyp#newco...
build/linux/system.gyp:355: 'defines' : ['HAVE_IBUS=1'],
nit: It seems there should be no space after 'defines'

[Peng, 2011-04-27 20:55:59]

http://codereview.chromium.org/6904053/diff/3002/build/linux/system.gyp
File build/linux/system.gyp (right):

http://codereview.chromium.org/6904053/diff/3002/build/linux/system.gyp#newco...
build/linux/system.gyp:355: 'defines' : ['HAVE_IBUS=1'],
On 2011/04/27 19:53:37, Paweł Hajdan Jr. wrote:
> nit: It seems there should be no space after 'defines'

Done.

[commit-bot: I haz the power, 2011-04-27 22:33:16]

Change committed as 83232