Simplify include dependencies.

Simplify include dependencies.

Try to make sure that accessors.h, data-flow.h, list-inl.h, and
scopeinfo.h are included only where needed, but without introducing
implicit dependencies.

Committed: http://code.google.com/p/v8/source/detail?r=7756

[Kevin Millikin (Chromium), 2011-05-02 16:37:00]

http://codereview.chromium.org/6903175/diff/2001/src/ast-inl.h
File src/ast-inl.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/ast-inl.h#newcode34
src/ast-inl.h:34: #include "scopes.h"
Clearly needed here, was getting it implicitly through ast.h somehow.

http://codereview.chromium.org/6903175/diff/2001/src/char-predicates.h
File src/char-predicates.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/char-predicates.h#newcode31
src/char-predicates.h:31: #include "unicode.h"
Clearly needed here, was relying on it being included before this file in .cc
files that use this one.

http://codereview.chromium.org/6903175/diff/2001/src/data-flow.h
File src/data-flow.h (left):

http://codereview.chromium.org/6903175/diff/2001/src/data-flow.h#oldcode205
src/data-flow.h:205: // An implementation of a sparse set whose elements are
drawn from integers
This is all dead code now.

http://codereview.chromium.org/6903175/diff/2001/src/hashmap.h
File src/hashmap.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/hashmap.h#newcode31
src/hashmap.h:31: #include "allocation.h"
Clearly needed, was relying on it being included before this file wherever used.

http://codereview.chromium.org/6903175/diff/2001/src/heap-inl.h
File src/heap-inl.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/heap-inl.h#newcode33
src/heap-inl.h:33: #include "list-inl.h"
Needed here, was getting it through spaces.h (indirectly).

http://codereview.chromium.org/6903175/diff/2001/src/list.h
File src/list.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/list.h#newcode31
src/list.h:31: #include "utils.h"
There was a cyclic dependency here.  list.h needs utils.h because it uses
Vector<T> in a type signature.  utils.h has a template class "Collector" and
subclasses that had a function defined in the header file that needed
List::Rewind from list-inl.h (which includes list.h and makes a cycle).

I broke it by introducing utils-inl.h to hold the single function from class
Collector, and including that in the one place where Collector was actually
moved.

That suggests that Collector (which seems too complicated to me for what it's
doing) doesn't belong in utils at all, but only in the module where it's used.

http://codereview.chromium.org/6903175/diff/2001/src/preparse-data.h
File src/preparse-data.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/preparse-data.h#newcode32
src/preparse-data.h:32: #include "utils-inl.h"
Relied on utils.h (now utils-inl.h) being included before preparse-data.h where
used.

This module is the only place that the Collector utility class seems to be used.

http://codereview.chromium.org/6903175/diff/2001/src/scanner-base.h
File src/scanner-base.h (left):

http://codereview.chromium.org/6903175/diff/2001/src/scanner-base.h#oldcode40
src/scanner-base.h:40: #include "list-inl.h"
Only here for the benefit of utils.h.

http://codereview.chromium.org/6903175/diff/2001/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/6903175/diff/2001/src/spaces.h#newcode31
src/spaces.h:31: #include "list.h"
A ton of stuff was getting the full list-inl.h file indirectly through spaces.h.

[Erik Corry, 2011-05-02 16:56:15]

LGTM.  I'm not mad keen on including -inl files in .h files, but there's lots of
good stuff here and I guess there's a good reason.