Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Side by Side Diff: test/mjsunit/debug-scripts-request.js

Issue 6903172: Use JSON.parse instead of eval for the debugger JSON protocol. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/debug-evaluate.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 // Test illegal scripts requests. 65 // Test illegal scripts requests.
66 testArguments(dcp, '{"types":"xx"}', false); 66 testArguments(dcp, '{"types":"xx"}', false);
67 67
68 // Test legal scripts requests. 68 // Test legal scripts requests.
69 testArguments(dcp, '{}', true); 69 testArguments(dcp, '{}', true);
70 testArguments(dcp, '{"types":1}', true); 70 testArguments(dcp, '{"types":1}', true);
71 testArguments(dcp, '{"types":2}', true); 71 testArguments(dcp, '{"types":2}', true);
72 testArguments(dcp, '{"types":4}', true); 72 testArguments(dcp, '{"types":4}', true);
73 testArguments(dcp, '{"types":7}', true); 73 testArguments(dcp, '{"types":7}', true);
74 testArguments(dcp, '{"types":0xFF}', true); 74 testArguments(dcp, '{"types":255}', true);
75 75
76 // Test request for all scripts. 76 // Test request for all scripts.
77 var request = '{' + base_request + '}' 77 var request = '{' + base_request + '}'
78 var response = safeEval(dcp.processDebugJSONRequest(request)); 78 var response = safeEval(dcp.processDebugJSONRequest(request));
79 assertTrue(response.success); 79 assertTrue(response.success);
80 80
81 // Test filtering by id. 81 // Test filtering by id.
82 assertEquals(2, response.body.length); 82 assertEquals(2, response.body.length);
83 var script = response.body[0]; 83 var script = response.body[0];
84 var request = '{' + base_request + ',"arguments":{"ids":[' + 84 var request = '{' + base_request + ',"arguments":{"ids":[' +
(...skipping 14 matching lines...) Expand all
99 // Add the debug event listener. 99 // Add the debug event listener.
100 Debug.setListener(listener); 100 Debug.setListener(listener);
101 101
102 // Call debugger to invoke the debug event listener. 102 // Call debugger to invoke the debug event listener.
103 debugger; 103 debugger;
104 104
105 // Make sure that the debug event listener vas invoked with no exceptions. 105 // Make sure that the debug event listener vas invoked with no exceptions.
106 assertTrue(listenerComplete, 106 assertTrue(listenerComplete,
107 "listener did not run to completion, exception: " + exception); 107 "listener did not run to completion, exception: " + exception);
108 assertFalse(exception, "exception in listener") 108 assertFalse(exception, "exception in listener")
OLDNEW
« no previous file with comments | « test/mjsunit/debug-evaluate.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698