Issue 6903153: Check for references to ${ROOT} in install_qa_checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6903153: Check for references to ${ROOT} in install_qa_checks. (Closed)

Created:
9 years, 7 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
zmedico, anush

CC:
chromium-os-reviews_chromium.org, zbehan, mtennant

Base URL:
git://git.overlays.gentoo.org/proj/portage.git@master

Visibility:
Public.

Description

Check for references to ${ROOT} in install_qa_checks. When ROOT != /, binaries that reference ROOT will load their dependencies from ROOT first rather than from the system-configured path. This is a problem because the ROOT will be / on the target system. Besides the above, this patch also fixes incorrect parsing of scanelf output, where we would treat the RPATHs returned by scanelf as the names of binaries. TEST=When "stricter" FEATURE is enabled, verify that emerge fails when an ebuild references broken rpaths referencing ROOT. When "stricter" FEATURE is not enabled, verify that such references are automatically fixed. Also verify that ebuilds with non-broken RPATHs (e.g. RPATHs referencing $ORIGIN/../lib) are not touched by the change. BUG=chromium-os:14271 Change-Id: I4f29cc4ea9195a1255f080284da1f676e4a2c26b R=anush@chromium.org,zmedico@gmail.com

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
	M	bin/misc-functions.sh	View	1 2 3 4 5 6	2 chunks	+26 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zmedico

9 years, 7 months ago (2011-04-30 00:26:57 UTC) #2

I've merged this upstream:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e483cb18...

I added this one line to make it behave more like before:

   vecho "Auto fixing rpaths for ${l%%:*}"

Expand Messages | Collapse Messages

Issue 6903153: Check for references to ${ROOT} in install_qa_checks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : s/SYSROOT/ROOT/g per zmedico #

Patch Set 3 : Be safe with whitespace #

Patch Set 4 : Unused var #

Patch Set 5 : Typo fix #

Patch Set 6 : Final version merged #

Patch Set 7 : Same patch, rebased against cros-2.1.9 branch #

Messages