Autofill Multi-Value: Additional profiles with same name and address not added to DOM UI

chrome/browser/autofill/personal_data_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 69 matching lines @@
   MessageLoopForUI message_loop_;
   BrowserThread ui_thread_;
   BrowserThread db_thread_;
   scoped_ptr<TestingProfile> profile_;
   scoped_refptr<PersonalDataManager> personal_data_;
   NotificationRegistrar registrar_;
   NotificationObserverMock observer_;
   PersonalDataLoadedObserverMock personal_data_observer_;
 };
 
+TEST_F(PersonalDataManagerTest, AddProfile) {
+  AutofillProfile profile0;
+  autofill_test::SetProfileInfo(&profile0,
+      "John", "Mitchell", "Smith",
+      "j@s.com", "Acme Inc.", "1 Main", "Apt A", "San Francisco", "CA",
+      "94102", "USA", "4158889999", "4152223333");
+
+  // This will verify that the web database has been loaded and the notification
+  // sent out.
+  EXPECT_CALL(personal_data_observer_,
+              OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
+
+  // The message loop will exit when the mock observer is notified.
+  MessageLoop::current()->Run();

[Ilya Sherman, 2011/04/27 23:32:43]

nit: Please move lines 97-103 to the top of the function, since they do not
depend on |profile0|.

[dhollowa, 2011/04/28 00:08:46]

Done.

+
+  // Add profile0 to the database.
+  personal_data_->AddProfile(profile0);
+
+  // Reload the database.
+  ResetPersonalDataManager();
+  EXPECT_CALL(personal_data_observer_,
+              OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
+  MessageLoop::current()->Run();
+
+  // Verify the addition.
+  const std::vector<AutofillProfile*>& results1 = personal_data_->profiles();
+  ASSERT_EQ(1U, results1.size());
+  EXPECT_EQ(0, profile0.CompareMulti(*results1.at(0)));
+
+  AutofillProfile profile0a;
+  autofill_test::SetProfileInfo(&profile0a,
+      "John", "Mitchell", "Smith",
+      "j@s.com", "Acme Inc.", "1 Main", "Apt A", "San Francisco", "CA",
+      "94102", "USA", "4158889999", "4152223333");
+  // Add profile with identical values.  Duplicates should not get saved.
+  personal_data_->AddProfile(profile0a);

[Ilya Sherman, 2011/04/27 23:32:43]

nit: Why not just """personal_data_->AddProfile(profile0);"""?

[dhollowa, 2011/04/28 00:08:46]

To ensure that the same guid values don't cause rejection.  I'm testing for the
values.  I agree with the comment below though, so I'll do a copy and generate a
new guid.

On 2011/04/27 23:32:43, Ilya Sherman wrote:

+
+  // Reload the database.
+  ResetPersonalDataManager();
+  EXPECT_CALL(personal_data_observer_,
+              OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
+  MessageLoop::current()->Run();
+
+  // Verify the non-addition.
+  const std::vector<AutofillProfile*>& results2 = personal_data_->profiles();
+  ASSERT_EQ(1U, results2.size());
+  EXPECT_EQ(0, profile0.CompareMulti(*results2.at(0)));
+
+  // New profile with different email.
+  AutofillProfile profile1;
+  autofill_test::SetProfileInfo(&profile1,
+      "John", "Mitchell", "Smith",
+      "john@smith.com", "Acme Inc.", "1 Main", "Apt A", "San Francisco", "CA",
+      "94102", "USA", "4158889999", "4152223333");

[Ilya Sherman, 2011/04/27 23:32:43]

nit: This would be tidier if written as:

AutofillProfile profile1 = profile0;
profile1.SetInfo(EMAIL_ADDRESS, "john@smith.com";

[dhollowa, 2011/04/28 00:08:46]

Done.  But the guid has to be accounted for.

+
+  // Add the different profile.  This should save as a separate profile.
+  // Note that if this same profile was "merged" it would collapse to one
+  // profile with a multi-valued entry for email.
+  personal_data_->AddProfile(profile1);
+
+  // Reload the database.
+  ResetPersonalDataManager();
+  EXPECT_CALL(personal_data_observer_,
+              OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
+  MessageLoop::current()->Run();
+
+  // Verify the addition.
+  const std::vector<AutofillProfile*>& results3 = personal_data_->profiles();
+  ASSERT_EQ(2U, results3.size());
+  EXPECT_EQ(0, profile0.CompareMulti(*results3.at(0)));
+  EXPECT_EQ(0, profile1.CompareMulti(*results3.at(1)));
+}
+
 // TODO(jhawkins): Test SetProfiles w/out a WebDataService in the profile.
 TEST_F(PersonalDataManagerTest, SetProfiles) {
   AutofillProfile profile0;
   autofill_test::SetProfileInfo(&profile0,
       "Marion", "Mitchell", "Morrison",
       "johnwayne@me.xyz", "Fox", "123 Zoo St.", "unit 5", "Hollywood", "CA",
       "91601", "US", "12345678910", "01987654321");
 
   AutofillProfile profile1;
   autofill_test::SetProfileInfo(&profile1,
@@ skipping 1635 matching lines @@
 
   // Expect that the newer information is saved.  In this case the year is
   // added to the existing credit card.
   CreditCard expected2;
   autofill_test::SetCreditCardInfo(&expected2,
       "Biggie Smalls", "4111111111111111", "01", "2011");
   const std::vector<CreditCard*>& results2 = personal_data_->credit_cards();
   ASSERT_EQ(1U, results2.size());
   EXPECT_EQ(0, expected2.Compare(*results2[0]));
 }