Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 6903059: Expose hasOwnProperty() through API. (Closed)

Created:
9 years, 8 months ago by Karl Klose
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Expose hasOwnProperty() through API. BUG=http://code.google.com/p/v8/issues/detail?id=1342 TEST=test-api/HasOwnProperty

Patch Set 1 #

Patch Set 2 : Update copyright years. #

Total comments: 2

Patch Set 3 : Add more testing. #

Total comments: 1

Patch Set 4 : Add one more test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -4 lines) Patch
M include/v8.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/api.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 2 chunks +114 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Karl Klose
9 years, 8 months ago (2011-04-27 08:53:12 UTC) #1
Vitaly Repeshko
Drive by comment. http://codereview.chromium.org/6903059/diff/5/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6903059/diff/5/test/cctest/test-api.cc#newcode214 test/cctest/test-api.cc:214: Handle<Object> object = value->ToObject(); It'd be ...
9 years, 8 months ago (2011-04-27 09:03:59 UTC) #2
Mads Ager (chromium)
I agree with Vitaly's comment. More testing is needed. The change itself looks good.
9 years, 8 months ago (2011-04-27 09:26:32 UTC) #3
Karl Klose
I added more testing, please have another look. http://codereview.chromium.org/6903059/diff/5/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6903059/diff/5/test/cctest/test-api.cc#newcode214 test/cctest/test-api.cc:214: Handle<Object> ...
9 years, 8 months ago (2011-04-28 08:32:43 UTC) #4
Mads Ager (chromium)
9 years, 8 months ago (2011-04-28 08:38:27 UTC) #5
LGTM

http://codereview.chromium.org/6903059/diff/1004/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6903059/diff/1004/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:13990: templ->SetNamedPropertyHandler(0, 0,
HasOwnPropertyNamedPropertyQuery);
Maybe add a case with interceptor getters and interceptor query that disagree on
which properties are there and check that the query method wins in connection
with HasOwnProperty.

Powered by Google App Engine
This is Rietveld 408576698