Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 6903056: Fix redistributeButtonsOnBarAsNeeded to not be confused by animation. Fixes bug where adding or d... (Closed)

Created:
9 years, 8 months ago by mafv
Modified:
9 years, 6 months ago
Reviewers:
mrossetti
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix redistributeButtonsOnBarAsNeeded to not be confused by animation. Fixes bug where adding or deleting buttons did not move other buttons between the bar and the overflow menu, since calculations were based on current positions of sliding buttons. TBR=mrossetti@chromium.org BUG=80580 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83105

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 3 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mafv
9 years, 8 months ago (2011-04-27 00:42:10 UTC) #1
mrossetti
9 years, 8 months ago (2011-04-27 01:00:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698