Removed wchar_t from Time::FromString

base/time.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time.h"
 #include "base/sys_string_conversions.h"
 #include "base/third_party/nspr/prtime.h"
 
 #include "base/logging.h"
 
@@ skipping 80 matching lines @@
   Exploded exploded;
   LocalExplode(&exploded);
   exploded.hour = 0;
   exploded.minute = 0;
   exploded.second = 0;
   exploded.millisecond = 0;
   return FromLocalExploded(exploded);
 }
 
 // static
-bool Time::FromString(const wchar_t* time_string, Time* parsed_time) {
+bool Time::FromString(const char* time_string, Time* parsed_time) {
   DCHECK((time_string != NULL) && (parsed_time != NULL));
-  std::string ascii_time_string = SysWideToUTF8(time_string);
-  if (ascii_time_string.length() == 0)
+
+  if (time_string[0] == '\0') {

[brettw, 2011/04/26 15:33:03]

Be consistent about {} usage for single-line conditionals. This means following
the code around you and not adding them here.

     return false;
+  }
+
   PRTime result_time = 0;
-  PRStatus result = PR_ParseTimeString(ascii_time_string.c_str(), PR_FALSE,
+  PRStatus result = PR_ParseTimeString(time_string, PR_FALSE,
                                        &result_time);
   if (PR_SUCCESS != result)
     return false;
   result_time += kTimeTToMicrosecondsOffset;
   *parsed_time = Time(result_time);
   return true;
+
 }
 
+#if 0

[brettw, 2011/04/26 15:33:03]

Why is this here commented out?

+// static
+bool Time::FromString(const wchar_t* time_string, Time* parsed_time) {
+  DCHECK((time_string != NULL) && (parsed_time != NULL));
+  std::string ascii_time_string = SysWideToUTF8(time_string);
+  return FromString(ascii_time_string.c_str(), parsed_time);
+}
+#endif
+
 // Time::Exploded -------------------------------------------------------------
 
 inline bool is_in_range(int value, int lo, int hi) {
   return lo <= value && value <= hi;
 }
 
 bool Time::Exploded::HasValidValues() const {
   return is_in_range(month, 1, 12) &&
          is_in_range(day_of_week, 0, 6) &&
          is_in_range(day_of_month, 1, 31) &&
          is_in_range(hour, 0, 23) &&
          is_in_range(minute, 0, 59) &&
          is_in_range(second, 0, 60) &&
          is_in_range(millisecond, 0, 999);
 }
 
 }  // namespace base