GTK: Add download notifications to the unity dock.

GTK: Integrate with the Unity desktop environment.

- When we're maximized and unity is active, don't draw the min/max/close buttons. Unity will take care of that in the title bar.
- When unity is active and we're downloading a file, badge the dock icon like we do on other platforms.

BUG=75485
TEST=Using a custom frame, maximize the window while running unity. We shouldn't draw our own min/max/close buttons.
TEST=Download a file on Natty; download count/progress bar should appear on dock icon.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83173

[Elliot Glaysher, 2011-04-26 00:22:52]

Screenshot to be sent immediately after.

[Elliot Glaysher, 2011-04-26 00:23:36]

Screenshot

On Mon, Apr 25, 2011 at 5:22 PM,  <erg@chromium.org> wrote:
> Reviewers: Evan Martin, Evan Stade,
>
> Message:
> Screenshot to be sent immediately after.
>
> Description:
> GTK: Add download notifications to the unity dock.
>
> I've left this generic because we may also want to implement Docky's DBUS
> API
> that does the same thing.
>
> BUG=none
> TEST=Download a file on Natty; download count/progress bar should appear on
> dock
> icon.
>
>
> Please review this at http://codereview.chromium.org/6903017/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/download/download_util.cc
>  A chrome/browser/ui/gtk/dock_service.h
>  A chrome/browser/ui/gtk/dock_service.cc
>  A chrome/browser/ui/gtk/unity_dock_service.h
>  A chrome/browser/ui/gtk/unity_dock_service.cc
>  M chrome/chrome_browser.gypi
>
>
>

[Evan Martin, 2011-04-26 00:33:52]

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:761: DockService* service =
DockService::GetService();
This appears to make blocking disk calls.  Do we care?

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/dock_s...
File chrome/browser/ui/gtk/dock_service.cc (right):

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/dock_s...
chrome/browser/ui/gtk/dock_service.cc:21: dock.reset(UnityDockService::Build());
Are there other dock services that you intend to support?

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/unity_...
File chrome/browser/ui/gtk/unity_dock_service.cc (right):

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/unity_...
chrome/browser/ui/gtk/unity_dock_service.cc:36: if (unity_lib) {
Why not early return here rather than nesting so much?

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/unity_...
File chrome/browser/ui/gtk/unity_dock_service.h (right):

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/unity_...
chrome/browser/ui/gtk/unity_dock_service.h:48:
unity_launcher_entry_set_count_func entry_set_count;
I feel like these are statics.  I feel like they sorta belong in the .cc in an
anon namespace.

[Elliot Glaysher, 2011-04-26 01:02:39]

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:761: DockService* service =
DockService::GetService();
On 2011/04/26 00:33:52, Evan Martin wrote:
> This appears to make blocking disk calls.  Do we care?

I'm not sure. The dlsym parts (I think) can be run on any thread, but I assume
that calling the unity functions have to happen on the UI thread due to DBUS.

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/dock_s...
File chrome/browser/ui/gtk/dock_service.cc (right):

http://codereview.chromium.org/6903017/diff/2001/chrome/browser/ui/gtk/dock_s...
chrome/browser/ui/gtk/dock_service.cc:21: dock.reset(UnityDockService::Build());
On 2011/04/26 00:33:52, Evan Martin wrote:
> Are there other dock services that you intend to support?

I would like (if I can figure out DBUS) to support Docky, but that's more a P3
and I just realized this architecture won't work.

I started reading the libunity source and it provides an UnityIsRunning()
method. If I remove the DockService interface, I can use it to detect unity for
the titlebar case. If we don't mind loading libunity at startup, that is...
WDYT?

[Elliot Glaysher, 2011-04-26 20:52:08]

I have completely changed the patch.

- Since discovering that libunity does all the logic of checking if unity is
running, hook up to that instead of rolling our own error prone dbus code.
- Fix the main problem with unity: we still display our buttons when maximized.
Detect that and hook up the signals to hide those buttons.
- Since I already did the dock badging, include that in this patch.

[Evan Martin, 2011-04-26 21:33:04]

I like the approach.

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/browser_...
File chrome/browser/ui/gtk/browser_titlebar.cc (right):

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/browser_...
chrome/browser/ui/gtk/browser_titlebar.cc:32: #include
"chrome/browser/ui/gtk/unity_service.h"
u comes after t

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
File chrome/browser/ui/gtk/unity_service.cc (right):

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
chrome/browser/ui/gtk/unity_service.cc:51: if (!attempted_load) {
Can early-exit this function rather than doing the whole thing indented.

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
chrome/browser/ui/gtk/unity_service.cc:53: if (unity_lib) {
Here too (if you set attempted_load=true) earlier.

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
chrome/browser/ui/gtk/unity_service.cc:103: return get_unity_running(inspector);
I'm concerned this is going to take a while, like doing a dbus query.  Maybe we
should cache it?  What does libunity actually do here?

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
File chrome/browser/ui/gtk/unity_service.h (right):

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
chrome/browser/ui/gtk/unity_service.h:21: void SetProgressPercent(float
percentage);
It's a little weird to call it 'percentage' when it ranges up to 1.
I'd call it 'fraction' for [0,1] or 'percentage' for [0,100].

[Elliot Glaysher, 2011-04-26 21:44:40]

TAL?

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
File chrome/browser/ui/gtk/unity_service.cc (right):

http://codereview.chromium.org/6903017/diff/22/chrome/browser/ui/gtk/unity_se...
chrome/browser/ui/gtk/unity_service.cc:103: return get_unity_running(inspector);
On 2011/04/26 21:33:04, Evan Martin wrote:
> I'm concerned this is going to take a while, like doing a dbus query.  Maybe
we
> should cache it?  What does libunity actually do here?

libunity reads a boolean. It modifies the boolean when it detects unity
grabbing/releasing the dbus service name. It's a O(1) operation.

[Evan Martin, 2011-04-26 21:50:20]

LGTM