Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 69029: If an external string enters the symbol table, make sure to set the... (Closed)

Created:
11 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

If an external string enters the symbol table, make sure to set the resource to NULL when removing it from the symbol table. This makes sure that the debugger can recognize the external string as being "deleted". Now, whenever an external resource is deleted, the resource pointer is set to NULL. This is really a workaround of a debugger problem. We need to make sure that the debugger only finds scripts in the heap that are actually live. Committed: http://code.google.com/p/v8/source/detail?r=1734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M src/mark-compact.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 8 months ago (2009-04-17 09:03:44 UTC) #1
Kasper Lund
11 years, 8 months ago (2009-04-17 09:05:59 UTC) #2
LGTM. We should push this to trunk (1.1.10.2) as soon as we're confident it
works well.

Powered by Google App Engine
This is Rietveld 408576698