Be more discriminating about uses of the arguments object in optimized code.

Be more discriminating about uses of the arguments object in optimized code.

Because we track the value of the arguments object, we need to check
values whenever plugged into a forbidden value context.  It is not
enough to check at only variable references as we did previously.

R=fschneider@chromium.org
BUG=1351
TEST=regress-1351.js

Committed: http://code.google.com/p/v8/source/detail?r=7739

[Kevin Millikin (Chromium), 2011-05-02 11:08:41]

http://codereview.chromium.org/6902202/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6902202/diff/1/src/hydrogen.cc#newcode3469
src/hydrogen.cc:3469: CHECK_ALIVE(VisitForValue(expr->value(),
arguments_allowed));
This is actually simpler, arguments is always allowed in this context.

[fschneider, 2011-05-02 11:12:49]

LGTM.