When start dragging event is detected, call hidePopups() to hide all popup windows.

content/renderer/render_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 1647 matching lines @@
 
 void RenderView::setToolTipText(const WebString& text, WebTextDirection hint) {
   Send(new ViewHostMsg_SetTooltipText(routing_id_, UTF16ToWideHack(text),
                                       hint));
 }
 
 void RenderView::startDragging(const WebDragData& data,
                                WebDragOperationsMask mask,
                                const WebImage& image,
                                const WebPoint& imageOffset) {
+  // We want to hide popups but don't want to clear filled filed.
+  if (webview()) {
+    webview()->hidePopups();
+    webview()->acceptCurrectAutoFilled();

[Ilya Sherman, 2011/05/07 09:07:10]

You probably want to swap the order of these two lines.

[honten.org, 2011/05/09 02:30:32]

Hmmm...

Even if I change the order of the calling, the debug assertion problem is not
figured out.

The problem is the following,
ASSERT(endingSelection().isNonOrphanedRange());

As you know, once we hide popup, the selected node is gone even if it's
accepted. Because the selection is the yellow color node displayed by Autofill
and it's gone after the accept. So that is the problem.

Actually, if we accept the node, we don't have to care orphaned. So only in this
case, we should not check the assertion. But to be strict behavior and to check
other cases, we have to pass the accepted info with flag not to check assertion,
right?

What do you think?


On 2011/05/07 09:07:10, Ilya Sherman wrote:

[Ilya Sherman, 2011/05/09 07:40:05]

As I mentioned on the WebKit bug, I don't fully understand why this code does
not behave the same as the code that handles the sequence of events

(1) User clicks to fill the form, thereby dismissing the popup menu.
(2) User drags text from a filled field to another field.

Ideally, we should behave exactly as that sequence of events does -- and share
code with it as much as possible.  What additional changes do we need to make to
achieve this matching behavior?

+  }
+
 #if WEBKIT_USING_SKIA
   SkBitmap bitmap(image.getSkBitmap());
 #elif WEBKIT_USING_CG
   SkBitmap bitmap = gfx::CGImageToSkBitmap(image.getCGImageRef());
 #endif
 
   Send(new DragHostMsg_StartDragging(routing_id_,
                                      WebDropData(data),
                                      mask,
                                      bitmap,
@@ skipping 2425 matching lines @@
     const webkit_glue::CustomContextMenuContext& custom_context) {
   if (custom_context.is_pepper_menu)
     pepper_delegate_.OnContextMenuClosed(custom_context);
   else
     context_menu_node_.reset();
 }
 
 void RenderView::OnNetworkStateChanged(bool online) {
   WebNetworkStateNotifier::setOnLine(online);
 }