Issue 6902177: linux components: expose more BASE_API used by Chrome itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6902177: linux components: expose more BASE_API used by Chrome itself (Closed)

Created:
9 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, agl, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

linux components: expose more BASE_API used by Chrome itself Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83629

Patch Set 1 #

Patch Set 2 : copyrights #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
M	base/file_util.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/global_descriptors_posix.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/linux_util.h	View	1	3 chunks	+4 lines, -2 lines	1 comment	Download
M	base/process_util.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/safe_strerror_posix.h	View	1	4 chunks	+5 lines, -3 lines	0 comments	Download
M	sandbox/linux/suid/process_util.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

9 years, 7 months ago (2011-04-29 23:17:20 UTC) #2

LGTM

http://codereview.chromium.org/6902177/diff/2001/base/linux_util.h
File base/linux_util.h (right):

http://codereview.chromium.org/6902177/diff/2001/base/linux_util.h#newcode35
base/linux_util.h:35: bool FindProcessHoldingSocket(pid_t* pid_out, ino_t
socket_inode);
I assume you want to wait until you find a caller before exporting the other
functions from this file.

Expand Messages | Collapse Messages