Add VideoCaptureImpl

content/renderer/media/video_capture_impl_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/message_loop.h"
+#include "content/renderer/media/video_capture_impl.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::_;
+using ::testing::Return;
+
+#define DEFAULT_CAPABILITY {176, 144, 30, 0, media::VideoFrame::I420, \

[scherkus (not reviewing), 2011/05/23 03:45:54]

you only use this once -- perhaps inline into test itself

[wjia(left Chromium), 2011/05/23 21:23:52]

Right now, only one simple test has been added. More tests will be added later,
therefore this literal will be used multiple times.

+    false, false }
+
+ACTION_P(DeleteMessage, return_value) {
+  delete arg0;
+  return return_value;
+}
+
+class MockVideoCaptureMessageFilter : public VideoCaptureMessageFilter {
+ public:
+  MockVideoCaptureMessageFilter() : VideoCaptureMessageFilter(1) {}
+  virtual ~MockVideoCaptureMessageFilter() {}
+
+  // Filter implementation.
+  MOCK_METHOD1(Send, bool(IPC::Message* message));
+  MOCK_METHOD0(ReadyToSend, bool());
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockVideoCaptureMessageFilter);
+};
+
+class MockVideoCaptureClient : public media::VideoCapture::EventHandler {
+ public:
+  MockVideoCaptureClient() {}
+  virtual ~MockVideoCaptureClient() {}
+
+  // Filter implementation.
+  MOCK_METHOD1(OnStarted, void(media::VideoCapture* capture));
+  MOCK_METHOD1(OnStopped, void(media::VideoCapture* capture));
+  MOCK_METHOD1(OnPaused, void(media::VideoCapture* capture));
+  MOCK_METHOD2(OnError, void(media::VideoCapture* capture, int error_code));
+  MOCK_METHOD2(OnBufferReady,
+               void(media::VideoCapture* capture,
+                    scoped_refptr<media::VideoCapture::VideoFrameBuffer> buf));
+  MOCK_METHOD2(OnDeviceInfoReceived,
+               void(media::VideoCapture* capture,
+                    const media::VideoCaptureParams& device_info));
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockVideoCaptureClient);
+};
+
+class VideoCaptureImplTest : public ::testing::Test {
+ public:
+  VideoCaptureImplTest() {
+    message_loop_.reset(new MessageLoop(MessageLoop::TYPE_IO));
+    message_loop_proxy_ =
+        base::MessageLoopProxy::CreateForCurrentThread().get();
+
+    message_filter_ = new MockVideoCaptureMessageFilter;
+    session_id_ = 1;
+
+    video_capture_impl_ = new VideoCaptureImpl(session_id_, message_loop_proxy_,
+                                               message_filter_);
+
+    video_capture_impl_->device_id_ = 2;
+  }
+
+  virtual ~VideoCaptureImplTest() {
+    delete video_capture_impl_;
+  }
+
+ protected:
+  scoped_ptr<MessageLoop> message_loop_;
+  scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
+  scoped_refptr<MockVideoCaptureMessageFilter> message_filter_;
+  media::VideoCaptureSessionId session_id_;
+  VideoCaptureImpl* video_capture_impl_;

[scherkus (not reviewing), 2011/05/23 03:45:54]

scoped_ptr?

[wjia(left Chromium), 2011/05/23 21:23:52]

VideoCaptureImpl has private ctor and dtor. Only VideoCaptureImplTest has been
added as friend class, not scoped_ptr<>.

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(VideoCaptureImplTest);
+};
+
+TEST_F(VideoCaptureImplTest, Simple) {
+  // Execute SetCapture() and StopCapture().
+
+  scoped_ptr<MockVideoCaptureClient> client(new MockVideoCaptureClient);
+  media::VideoCapture::VideoCaptureCapability capability = DEFAULT_CAPABILITY;
+
+  EXPECT_CALL(*message_filter_, Send(_))
+      .WillRepeatedly(DeleteMessage(true));
+
+  EXPECT_CALL(*message_filter_, ReadyToSend())
+      .WillRepeatedly(Return(true));
+
+  EXPECT_CALL(*client, OnStarted(_))
+      .WillOnce(Return());
+
+  EXPECT_CALL(*client, OnStopped(_))

[scherkus (not reviewing), 2011/05/23 03:45:54]

I think it'd make more sense to move this call to after the call to
StartCapture() 

[wjia(left Chromium), 2011/05/23 21:23:52]

Done.

+      .WillOnce(Return());
+
+  video_capture_impl_->StartCapture(client.get(), capability);
+  video_capture_impl_->StopCapture(client.get());
+}