Issue 6902144: Handle join of sparse arrays with non-empty separator more efficiently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6902144: Handle join of sparse arrays with non-empty separator more efficiently. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Handle join of sparse arrays with non-empty separator more efficiently. BUG=v8:1028

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test for empty separator. Fix brainfart. #

Created: 9 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -13 lines)
M	src/array.js	View	4 chunks	+32 lines, -10 lines	0 comments
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments
M	src/runtime.cc	View	1 chunk	+129 lines, -0 lines	0 comments
M	test/mjsunit/array-join.js	View	4 chunks	+26 lines, -3 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 8 months ago (2011-04-29 08:21:22 UTC) #2

LGTM with an additional test case.

http://codereview.chromium.org/6902144/diff/1/src/array.js
File src/array.js (left):

http://codereview.chromium.org/6902144/diff/1/src/array.js#oldcode132
src/array.js:132: if (!IS_UNDEFINED(e)) {
Is this a bug fix or does it change the behavior? We should have a test case
hitting this to verify that this is the right thing to do.

Expand Messages | Collapse Messages