Make component=shared_library gyp build work for Linux.

Make component=shared_library gyp build work for Linux.

Committed: http://code.google.com/p/v8/source/detail?r=7751

[Evan Martin, 2011-04-28 22:15:59]

mads for review,
rvargas FYI.

To make gyp happy I want to include a source file even on the non-Windows
builds, so I used v8dll-main to simplify the gyp files.  But note that due to
#ifdefs it shouldn't have any content.  Let me know if you have better ideas for
that (I'm not sure if checking _WIN32 is the right v8 way, for example).

[Mads Ager (chromium), 2011-04-29 05:53:17]

LGTM

+sgjesse FYI

http://codereview.chromium.org/6902128/diff/2001/src/v8dll-main.cc
File src/v8dll-main.cc (right):

http://codereview.chromium.org/6902128/diff/2001/src/v8dll-main.cc#newcode30
src/v8dll-main.cc:30: #ifdef _WIN32
In V8 we have a WIN32 define without the underscore.

#ifdef WIN32

[Søren Thygesen Gjesse, 2011-04-29 06:21:42]

LGTM

http://codereview.chromium.org/6902128/diff/2001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/6902128/diff/2001/tools/gyp/v8.gyp#newcode192
tools/gyp/v8.gyp:192: 'sources': [
So the GYP issue is that you cannot just exclude this file on Linux. Maybe add a
comment that this "DLL" related file is actually included on all platforms.

[Evan Martin, 2011-04-29 21:17:09]

new version up

http://codereview.chromium.org/6902128/diff/2001/src/v8dll-main.cc
File src/v8dll-main.cc (right):

http://codereview.chromium.org/6902128/diff/2001/src/v8dll-main.cc#newcode30
src/v8dll-main.cc:30: #ifdef _WIN32
On 2011/04/29 05:53:17, Mads Ager wrote:
> In V8 we have a WIN32 define without the underscore.
> 
> #ifdef WIN32

I picked this one by grepping for WIN32.

$ ack-grep 'ifdef _WIN32' | less
include/v8-profiler.h:33:#ifdef _WIN32
include/v8-debug.h:33:#ifdef _WIN32
include/v8-testing.h:33:#ifdef _WIN32
include/v8.h:43:#ifdef _WIN32
include/v8-preparser.h:33:#ifdef _WIN32
src/v8dll-main.cc:30:#ifdef _WIN32

I'll switch.

http://codereview.chromium.org/6902128/diff/2001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/6902128/diff/2001/tools/gyp/v8.gyp#newcode192
tools/gyp/v8.gyp:192: 'sources': [
On 2011/04/29 06:21:42, Søren Gjesse wrote:
> So the GYP issue is that you cannot just exclude this file on Linux. Maybe add
a
> comment that this "DLL" related file is actually included on all platforms.

OK.

[Søren Thygesen Gjesse, 2011-05-02 07:50:24]

LGTM

[Evan Martin, 2011-05-02 14:50:28]

Can you land this for me when you get the chance?  :)

[Mads Ager (chromium), 2011-05-02 15:07:29]

On 2011/05/02 14:50:28, Evan Martin wrote:
> Can you land this for me when you get the chance?  :)

Done. Thanks! :)