src/x64/lithium-x64.cc - Issue 6902112: Avoid using a register for constant external array indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 6902112: Avoid using a register for constant external array indices. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: add arch-independent ExternalArrayTypeToShiftSize() function Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 7ca7c05c4c1d92ac391843c0a4875087dd0b2645..0e18b1c93e714fb50addc038c438ac2a64e9d702 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -1851,7 +1851,7 @@ LInstruction* LChunkBuilder::DoLoadKeyedSpecializedArrayElement(

array_type == kExternalDoubleArray)));

ASSERT(instr->key()->representation().IsInteger32());

LOperand* external_pointer = UseRegister(instr->external_pointer());

- LOperand* key = UseRegister(instr->key());

+ LOperand* key = UseRegisterOrConstant(instr->key());

LLoadKeyedSpecializedArrayElement* result =

new LLoadKeyedSpecializedArrayElement(external_pointer, key);

LInstruction* load_instr = DefineAsRegister(result);

@@ -1908,7 +1908,7 @@ LInstruction* LChunkBuilder::DoStoreKeyedSpecializedArrayElement(

LOperand* val = val_is_temp_register

? UseTempRegister(instr->value())

: UseRegister(instr->value());

- LOperand* key = UseRegister(instr->key());

+ LOperand* key = UseRegisterOrConstant(instr->key());

return new LStoreKeyedSpecializedArrayElement(external_pointer,

key,

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »