src/ia32/lithium-ia32.cc - Issue 6902112: Avoid using a register for constant external array indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-ia32.cc

Issue 6902112: Avoid using a register for constant external array indices. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: add arch-independent ExternalArrayTypeToShiftSize() function Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-ia32.cc

diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc

index 7329660e5898291c4456018ba6523ac121074615..9b61870781a3a56fb36537fd7b67a926cb64e162 100644

--- a/src/ia32/lithium-ia32.cc

+++ b/src/ia32/lithium-ia32.cc

@@ -1895,7 +1895,7 @@ LInstruction* LChunkBuilder::DoLoadKeyedSpecializedArrayElement(

array_type == kExternalDoubleArray)));

ASSERT(instr->key()->representation().IsInteger32());

LOperand* external_pointer = UseRegister(instr->external_pointer());

- LOperand* key = UseRegister(instr->key());

+ LOperand* key = UseRegisterOrConstant(instr->key());

LLoadKeyedSpecializedArrayElement* result =

new LLoadKeyedSpecializedArrayElement(external_pointer,

key);

@@ -1950,7 +1950,7 @@ LInstruction* LChunkBuilder::DoStoreKeyedSpecializedArrayElement(

ASSERT(instr->key()->representation().IsInteger32());

LOperand* external_pointer = UseRegister(instr->external_pointer());

- LOperand* key = UseRegister(instr->key());

+ LOperand* key = UseRegisterOrConstant(instr->key());

LOperand* temp = NULL;

if (array_type == kExternalPixelArray) {

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/lithium.h » ('j') | no next file with comments »