src/x64/lithium-codegen-x64.h - Issue 6902112: Avoid using a register for constant external array indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.h

Issue 6902112: Avoid using a register for constant external array indices. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.h

diff --git a/src/x64/lithium-codegen-x64.h b/src/x64/lithium-codegen-x64.h

index 17c12897cfe20587af0a0fb40c7347ac7690a723..d7bbc7161e74823b31921cd126f2283cf52921c4 100644

--- a/src/x64/lithium-codegen-x64.h

+++ b/src/x64/lithium-codegen-x64.h

@@ -214,6 +214,9 @@ class LCodeGen BASE_EMBEDDED {

XMMRegister ToDoubleRegister(int index) const;

+ Operand BuildExternalArrayOperand(LOperand* external_pointer,

+ LOperand* key,

+ ExternalArrayType array_type);

// Specific math operations - used from DoUnaryMathOperation.

void EmitIntegerMathAbs(LUnaryMathOperation* instr);

« src/ia32/lithium-codegen-ia32.cc ('K') | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | src/x64/lithium-codegen-x64.cc » ('J')